Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADO Extension] E2E tests #866

Closed
lisli1 opened this issue Sep 23, 2021 · 2 comments · Fixed by #1372
Closed

[ADO Extension] E2E tests #866

lisli1 opened this issue Sep 23, 2021 · 2 comments · Fixed by #1372
Labels
category: engineering status: active This issue is currently being worked on by someone.

Comments

@lisli1
Copy link
Contributor

lisli1 commented Sep 23, 2021

E2E tests were disabled in #844 due to an issue in webpack. When it is resolved, the tests will need to be turned back on.
@lisli1 lisli1 added the status: blocked This issue is blocked. label Sep 23, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Sep 23, 2021
@ghost ghost assigned lisli1 Sep 23, 2021
@lisli1 lisli1 removed their assignment Sep 23, 2021
@lisli1 lisli1 removed the status: new This issue is new and requires triage by DRI. label Sep 23, 2021
@asksep
Copy link
Contributor

asksep commented Aug 8, 2022

The GitHub Repo token usage is obsolete, therefor the Accessibility Insights team is going to investigate enabling new E2E tests

@asksep asksep added status: ready for work This issue is ready to be worked on. and removed status: blocked This issue is blocked. labels Aug 8, 2022
@katydecorah katydecorah mentioned this issue Aug 10, 2022
Merged
4 tasks
@katydecorah
Copy link
Contributor

I'm moving this backed to blocked. https://github.com/microsoft/azure-pipelines-task-lib updated azure-pipelines-task-lib/mock-test with Node 16 but hasn't release yet. This means that the e2e tests run on Node 10 and then fails when it runs the scan package (which requires Node 16).

@katydecorah katydecorah added status: blocked This issue is blocked. and removed status: ready for work This issue is ready to be worked on. labels Aug 15, 2022
@ThanyaLeif ThanyaLeif mentioned this issue Nov 3, 2022
Merged
5 tasks
@katydecorah katydecorah added status: active This issue is currently being worked on by someone. and removed status: blocked This issue is blocked. labels Nov 14, 2022
katydecorah added a commit that referenced this issue Nov 14, 2022
@ThanyaLeif @katydecorah
fix: Reenabling E2E test (#1372)
7c83209 
#### Details

This PR reenables E2E test after azure-pipelines-task-lib latest
release.

##### Motivation
Add an extra layer of security to ensure future code changes don't break
the Extension

##### Context
Since E2E tests were disabled a year ago when the Extension was in an
early stage of development, it was necessary some workarounds that
include:

* Switching from Mocha to Jest as a test framework
* Refactoring of the `run.ts` class, now `run-simple-inputs.js`,
responsible for setting the environment for the E2E tests.
* Updating `azure-pipeline-task-lib` to v4.0.1-preview that has a fix
for a problem found in
[#794](microsoft/azure-pipelines-task-lib#794)
* Creating a local mock-test file to work around Node issues seen in the
pipeline.
* Updating the GitHub workflow to run e2e tests on PR.

These changes will affect ADO extension's side exclusively.

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [x] Addresses an existing issue: Fixes #866 
- [x] Added relevant unit test for your changes. (`yarn test`)
- [ ] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] Ran precheckin (`yarn precheckin`)
- [x] Described how this PR impacts both the ADO extension and the
GitHub action

Co-authored-by: Tania Martinez Villagomez <[email protected]>
Co-authored-by: Katy DeCorah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: engineering status: active This issue is currently being worked on by someone.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Reenabling E2E test microsoft/accessibility-insights-action
4 participants
@katydecorah @asksep @RobGallo @lisli1