Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check using "super" before "this" lexically #6860

Merged
merged 11 commits into from
Feb 11, 2016
Merged

Check using "super" before "this" lexically #6860

merged 11 commits into from
Feb 11, 2016

Commits on Feb 3, 2016

  1. add conformance tests

    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    a5cf7c1 View commit details
    Browse the repository at this point in the history

  2. Update baselines 

    add baselines

Update baseline
    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    76b6bff View commit details
    Browse the repository at this point in the history

  3. Check using "super" before "this" lexically instead of using the 

    NodeCheckFlags

Remove "type-checking" way of checking if super is used before this.
Instead check using whether super occurs before this syntactically

Refactor the code

Dive down to get super call
    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    ed09628 View commit details
    Browse the repository at this point in the history

  4. Address PR

    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    7e1088b View commit details
    Browse the repository at this point in the history

  5. Address PR about tests

    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    2dbc998 View commit details
    Browse the repository at this point in the history

  6. Add a flag so we don't repeatedly finding super call

    Kanchalai Tanglertsampan committed Feb 3, 2016
    Configuration menu
    Copy the full SHA
    aff6775 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2016

  1. rename function

    Kanchalai Tanglertsampan committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    1d4c1d1 View commit details
    Browse the repository at this point in the history

  2. Move tests into correct location

    Kanchalai Tanglertsampan committed Feb 4, 2016
    Configuration menu
    Copy the full SHA
    47a2f3b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2016

  1. Merge branch 'release-1.8' into checksuperbeforethislexically

    Kanchalai Tanglertsampan committed Feb 8, 2016
    Configuration menu
    Copy the full SHA
    1cfce12 View commit details
    Browse the repository at this point in the history

  2. Address PR

    Kanchalai Tanglertsampan committed Feb 8, 2016
    Configuration menu
    Copy the full SHA
    dc8e0cc View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2016

  1. Address PR: report error on super call instead of entire constructor … 

    …node
    Kanchalai Tanglertsampan committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    61e954b View commit details
    Browse the repository at this point in the history