Check using "super" before "this" lexically

[yuit]

With previous approach @ahejlsberg pointed out, it fails in the following case

class Base {
       constructor(c) { }
 }
class D extends Base {
       private _t;
       constructor() {
            super(i);
            var s = {
               t: this._t  // incorrect reported an error
           } 
           var i = Factory.create(s);  // if this is changed to var  i = undefined; error no longer reported
       }
}

This behavior is due to the fact that when the compiler is in the middle of checking super, it will then go and try to resolve i which then try to go resolve s which cause checkThisExpression to be called before the NodeCheckFlags.HasSeenSuperCall is set.

@ahejlsberg suggests a new approach to check if super is called before this lexically. This approached will be more robust against type-checker diving down when type-checking particular statement.

The fix also includes not-erroring when extends null as pointed out by @rbuckton

[DanielRosenwasser]

getSuperCallInConstructor

[yuit]

@DanielRosenwasser @vladima Any more comments?

[DanielRosenwasser]

This function already exists elsewhere, so you can remove this one.

[DanielRosenwasser]

Currently you're erroring on the constructor node itself, which gives a pretty unpleasant experience (it errors on the entire body as well).

You should report an error on the super call that you were able to find.

[mhegazy]

👍

[mhegazy]

Please port this to master as well.

[coveralls]

Changes Unknown when pulling 61e954b on checksuperbeforethislexically into ** on release-1.8**.

[RyanCavanaugh]

@coveralls why are you here?