Narrow by clause expressions in switches with `true` condition #53681

Andarist · 2023-04-05T22:05:18Z

typescript-bot · 2023-04-05T22:05:23Z

The TypeScript team hasn't accepted the linked issue #37178. If you can get it accepted, this PR will have a better chance of being reviewed.

fatcerberus · 2023-04-06T03:33:16Z

I personally hate this pattern (it feels like the bastard child of JS switch..case and Haskell case expressions) but people ask for TS to support it often enough that I'm not going to argue 😝

I guess it could save you from typing a bunch of parentheses... ~~in exchange for a bunch of break statements~~ 🚎

codingedgar · 2023-04-06T05:46:20Z

I personally hate this pattern (it feels like the bastard child of JS switch..case and Haskell case expressions) but people ask for TS to support it often enough that I'm not going to argue 😝

I guess it could save you from typing a bunch of parentheses... ~~in exchange for a bunch of break statements~~ 🚎

Seems to be valid js tho https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch#an_alternative_to_if...else_chains

Supporting it is nice 👌

fatcerberus · 2023-04-06T06:13:20Z

To be fair, the bar is usually a wee bit higher than "it works in JS" 😉 but yes, I agree that if people are regularly writing code like this, it's nice to support it.

jakebailey · 2023-04-18T23:32:19Z

Is the issue actually accepted?

jakebailey · 2023-04-18T23:32:51Z

(Code looks good, though.)

Andarist · 2023-04-18T23:36:08Z

Technically it doesnt have the corresponding label - if that’s what you are asking about. This feature was requested multiple times throughout the years and its a pattern mentioned in MDN docs so i jumped the gun on it and just implemented it as an excercise to learn more about CFA implementation in the compiler

Andarist · 2023-04-19T16:41:24Z

src/compiler/checker.ts

+                const clause = flow.switchStatement.caseBlock.clauses.find((_, index) => index === flow.clauseStart);
+                const clauseExpression = clause && clause.kind === SyntaxKind.CaseClause ? clause.expression : undefined;
+                if (clauseExpression) {
+                    type = narrowType(type, clauseExpression, /*assumeTrue*/ true);


I should probably use narrowTypeByEquality here or something and add corresponding tests

I re-examined this and I don't think this is needed anyhow here.

jakebailey · 2023-08-29T21:40:27Z

@typescript-bot perf test this

typescript-bot · 2023-08-29T21:40:31Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 7bff88a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-08-29T22:11:40Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{300,278k (± 0.01%)}	_{300,269k (± 0.01%)}	_~	_300,254k	_300,295k	_{p=0.422 n=6}
_{Parse Time}	_{3.00s (± 0.27%)}	_{3.01s (± 0.35%)}	_~	_2.99s	_3.02s	_{p=0.865 n=6}
_{Bind Time}	_{0.93s (± 0.44%)}	_{0.93s (± 0.00%)}	_~	_0.93s	_0.93s	_{p=0.405 n=6}
_{Check Time}	_{9.33s (± 0.25%)}	_{9.29s (± 0.45%)}	_~	_9.24s	_9.36s	_{p=0.091 n=6}
_{Emit Time}	_{7.61s (± 0.11%)}	_{7.62s (± 0.27%)}	_~	_7.59s	_7.65s	_{p=0.565 n=6}
_{Total Time}	_{20.88s (± 0.09%)}	_{20.85s (± 0.24%)}	_~	_20.80s	_20.93s	_{p=0.332 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,942k (± 0.02%)}	_{194,469k (± 0.67%)}	_~	_193,866k	_197,113k	_{p=0.630 n=6}
_{Parse Time}	_{1.58s (± 0.00%)}	_{1.58s (± 0.00%)}	_~	_1.58s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.80s (± 0.00%)}	_{0.80s (± 0.51%)}	_~	_0.79s	_0.80s	_{p=0.405 n=6}
_{Check Time}	_{9.94s (± 0.31%)}	_{9.93s (± 0.44%)}	_~	_9.86s	_9.96s	_{p=0.806 n=6}
_{Emit Time}	_{2.74s (± 0.36%)}	_{2.74s (± 0.23%)}	_~	_2.73s	_2.75s	_{p=0.733 n=6}
_{Total Time}	_{15.05s (± 0.25%)}	_{15.04s (± 0.31%)}	_~	_14.97s	_15.08s	_{p=1.000 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{347,200k (± 0.00%)}	_{347,187k (± 0.01%)}	_~	_347,140k	_347,213k	_{p=0.296 n=6}
_{Parse Time}	_{2.69s (± 0.19%)}	_{2.68s (± 0.44%)}	_~	_2.67s	_2.70s	_{p=0.351 n=6}
_{Bind Time}	_{0.99s (± 0.83%)}	_{0.99s (± 0.41%)}	_~	_0.98s	_0.99s	_{p=1.000 n=6}
_{Check Time}	_{7.93s (± 0.26%)}	_{7.93s (± 0.35%)}	_~	_7.90s	_7.96s	_{p=0.516 n=6}
_{Emit Time}	_{4.26s (± 0.27%)}	_{4.25s (± 0.42%)}	_~	_4.22s	_4.27s	_{p=0.324 n=6}
_{Total Time}	_{15.87s (± 0.19%)}	_{15.85s (± 0.32%)}	_~	_15.78s	_15.91s	_{p=0.422 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{301,176k (± 0.00%)}	_{301,180k (± 0.01%)}	_~	_301,152k	_301,203k	_{p=0.468 n=6}
_{Parse Time}	_{2.17s (± 0.39%)}	_{2.18s (± 0.96%)}	_~	_2.16s	_2.22s	_{p=0.109 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.37%)}	_~	_1.10s	_1.11s	_{p=0.218 n=6}
_{Check Time}	_{7.22s (± 0.32%)}	_{7.22s (± 0.26%)}	_~	_7.20s	_7.25s	_{p=0.935 n=6}
_{Emit Time}	_{3.99s (± 0.54%)}	_{3.99s (± 0.41%)}	_~	_3.98s	_4.01s	_{p=0.684 n=6}
_{Total Time}	_{14.49s (± 0.19%)}	_{14.50s (± 0.19%)}	_~	_14.47s	_14.54s	_{p=0.330 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{479,467k (± 0.00%)}	_{479,460k (± 0.00%)}	_~	_479,440k	_479,475k	_{p=0.688 n=6}
_{Parse Time}	_{3.14s (± 0.13%)}	_{3.15s (± 0.37%)}	_~	_3.14s	_3.17s	_{p=0.087 n=6}
_{Bind Time}	_{0.91s (± 0.00%)}	_{0.91s (± 0.45%)}	_~	_0.90s	_0.91s	_{p=0.405 n=6}
_{Check Time}	_{17.86s (± 0.32%)}	_{17.79s (± 0.32%)}	_~	_17.71s	_17.85s	_{p=0.090 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.92s (± 0.28%)}	_{21.85s (± 0.31%)}	_~	_21.75s	_21.93s	_{p=0.227 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{542,843k (± 0.02%)}	_{542,834k (± 0.02%)}	_~	_542,760k	_542,992k	_{p=0.810 n=6}
_{Parse Time}	_{3.69s (± 0.20%)}	_{3.69s (± 0.22%)}	_~	_3.68s	_3.70s	_{p=0.729 n=6}
_{Bind Time}	_{1.41s (± 4.48%)}	_{1.40s (± 4.31%)}	_~	_1.34s	_1.45s	_{p=0.863 n=6}
_{Check Time}	_{3.26s (± 2.44%)}	_{3.25s (± 2.42%)}	_~	_3.17s	_3.34s	_{p=0.514 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=0.405 n=6}
_{Total Time}	_{8.45s (± 0.64%)}	_{8.42s (± 0.33%)}	_~	_8.39s	_8.46s	_{p=0.295 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,491ms (± 0.13%)}	_{2,489ms (± 0.14%)}	_~	_2,485ms	_2,495ms	_{p=0.292 n=6}
_{Req 2 - geterr}	_{5,934ms (± 0.37%)}	_{5,939ms (± 0.56%)}	_~	_5,911ms	_5,994ms	_{p=0.873 n=6}
_{Req 3 - references}	_{343ms (± 0.30%)}	_{343ms (± 0.24%)}	_~	_342ms	_344ms	_{p=0.932 n=6}
_{Req 4 - navto}	_{277ms (± 0.23%)}	_{279ms (± 0.74%)}	_~	_276ms	_281ms	_{p=0.179 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 5.23%)}	_{81ms (± 3.12%)}	_~	_76ms	_83ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,624ms (± 0.78%)}	_{2,622ms (± 0.66%)}	_~	_2,608ms	_2,653ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,780ms (± 0.21%)}	_{4,771ms (± 0.19%)}	_~	_4,763ms	_4,783ms	_{p=0.199 n=6}
_{Req 3 - references}	_{351ms (± 0.18%)}	_{350ms (± 0.23%)}	_~	_349ms	_351ms	_{p=0.177 n=6}
_{Req 4 - navto}	_{269ms (± 0.30%)}	_{270ms (± 0.30%)}	_~	_269ms	_271ms	_{p=0.666 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{79ms (± 0.66%)}	_{79ms (± 0.00%)}	_~	_79ms	_79ms	_{p=0.174 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,710ms (± 0.18%)}	_{2,710ms (± 0.21%)}	_~	_2,703ms	_2,718ms	_{p=0.686 n=6}
_{Req 2 - geterr}	_{1,948ms (± 1.81%)}	_{1,969ms (± 0.40%)}	_~	_1,958ms	_1,978ms	_{p=0.575 n=6}
_{Req 3 - references}	_{137ms (± 2.82%)}	_{136ms (± 6.93%)}	_~	_117ms	_141ms	_{p=0.681 n=6}
_{Req 4 - navto}	_{353ms (± 0.53%)}	_{352ms (± 0.38%)}	_~	_351ms	_354ms	_{p=0.155 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{320ms (± 1.74%)}	_{322ms (± 1.63%)}	_~	_314ms	_326ms	_{p=0.747 n=6}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

CompilerTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
xstateTSServer - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{156.12ms (± 0.16%)}	_{156.26ms (± 0.15%)}	_{+0.13ms (+ 0.09%)}	_154.38ms	_158.48ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{230.12ms (± 0.14%)}	_{230.79ms (± 0.14%)}	_{+0.67ms (+ 0.29%)}	_229.13ms	_235.19ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.03ms (± 0.13%)}	_{235.98ms (± 0.14%)}	_{+0.95ms (+ 0.41%)}	_234.48ms	_242.85ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{235.95ms (± 0.12%)}	_{235.82ms (± 0.25%)}	_{-0.13ms (- 0.05%)}	_234.09ms	_259.32ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Andarist · 2023-09-11T12:54:23Z

I came back to this after a while and I think this is actually ready to be reviewed.

jakebailey · 2023-09-15T22:43:13Z

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at db28e0c. You can monitor the build here.

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at db28e0c. You can monitor the build here.

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-15T22:43:16Z

Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-15T22:45:28Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157766/artifacts?artifactName=tgz&fileId=EF74DF05B649ED2E326973EA68905C7E7E36A9296FF087C24257A4AA04130BF102&fileName=/typescript-5.3.0-insiders.20230915.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

jakebailey

LGTM so long as everything comes back clean.

typescript-bot · 2023-09-15T22:59:15Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53681/merge:

Everything looks good!

typescript-bot · 2023-09-15T23:03:23Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53681/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
2 instances of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-09-15T23:07:43Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{294,914k (± 0.01%)}	_{294,898k (± 0.01%)}	_~	_294,854k	_294,935k	_{p=0.471 n=6}
_{Parse Time}	_{2.63s (± 0.54%)}	_{2.63s (± 0.29%)}	_~	_2.62s	_2.64s	_{p=0.867 n=6}
_{Bind Time}	_{0.84s (± 0.65%)}	_{0.85s (± 0.61%)}	_~	_0.84s	_0.85s	_{p=0.640 n=6}
_{Check Time}	_{8.03s (± 0.36%)}	_{8.00s (± 0.25%)}	_~	_7.96s	_8.02s	_{p=0.076 n=6}
_{Emit Time}	_{7.03s (± 0.26%)}	_{7.01s (± 0.21%)}	_~	_6.99s	_7.03s	_{p=0.070 n=6}
_{Total Time}	_{18.53s (± 0.24%)}	_{18.48s (± 0.10%)}	_~	_18.46s	_18.51s	_{p=0.065 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,544k (± 1.51%)}	_{192,567k (± 1.51%)}	_~	_190,644k	_196,339k	_{p=0.471 n=6}
_{Parse Time}	_{1.35s (± 0.60%)}	_{1.35s (± 0.47%)}	_~	_1.34s	_1.36s	_{p=0.432 n=6}
_{Bind Time}	_{0.74s (± 0.00%)}	_{0.74s (± 0.00%)}	_~	_0.74s	_0.74s	_{p=1.000 n=6}
_{Check Time}	_{9.03s (± 0.69%)}	_{9.06s (± 0.44%)}	_~	_9.01s	_9.12s	_{p=0.375 n=6}
_{Emit Time}	_{2.60s (± 0.71%)}	_{2.61s (± 0.71%)}	_~	_2.58s	_2.63s	_{p=0.372 n=6}
_{Total Time}	_{13.73s (± 0.37%)}	_{13.77s (± 0.33%)}	_~	_13.71s	_13.84s	_{p=0.226 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,170k (± 0.01%)}	_{347,160k (± 0.01%)}	_~	_347,142k	_347,182k	_{p=0.296 n=6}
_{Parse Time}	_{2.46s (± 0.40%)}	_{2.46s (± 0.54%)}	_~	_2.44s	_2.47s	_{p=0.396 n=6}
_{Bind Time}	_{0.93s (± 0.55%)}	_{0.94s (± 0.55%)}	_~	_0.93s	_0.94s	_{p=0.311 n=6}
_{Check Time}	_{6.87s (± 0.41%)}	_{6.88s (± 0.71%)}	_~	_6.82s	_6.95s	_{p=0.936 n=6}
_{Emit Time}	_{4.04s (± 0.31%)}	_{4.05s (± 0.60%)}	_~	_4.02s	_4.09s	_{p=0.805 n=6}
_{Total Time}	_{14.30s (± 0.18%)}	_{14.32s (± 0.44%)}	_~	_14.25s	_14.41s	_{p=0.520 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,453k (± 0.00%)}	_{302,461k (± 0.01%)}	_~	_302,439k	_302,493k	_{p=0.748 n=6}
_{Parse Time}	_{2.01s (± 0.54%)}	_{2.01s (± 0.51%)}	_~	_1.99s	_2.02s	_{p=0.546 n=6}
_{Bind Time}	_{0.99s (± 1.04%)}	_{1.00s (± 1.17%)}	_~	_0.99s	_1.02s	_{p=0.241 n=6}
_{Check Time}	_{6.25s (± 0.22%)}	_{6.23s (± 0.29%)}	_~	_6.21s	_6.25s	_{p=0.182 n=6}
_{Emit Time}	_{3.52s (± 0.51%)}	_{3.54s (± 0.30%)}	_~	_3.52s	_3.55s	_{p=0.123 n=6}
_{Total Time}	_{12.77s (± 0.21%)}	_{12.78s (± 0.15%)}	_~	_12.75s	_12.80s	_{p=0.332 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{470,440k (± 0.01%)}	_{470,434k (± 0.01%)}	_~	_470,343k	_470,493k	_{p=0.873 n=6}
_{Parse Time}	_{2.59s (± 0.47%)}	_{2.59s (± 0.76%)}	_~	_2.56s	_2.61s	_{p=0.366 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.00s (± 1.17%)}	_~	_0.98s	_1.01s	_{p=0.673 n=6}
_{Check Time}	_{16.53s (± 0.37%)}	_{16.59s (± 0.39%)}	_~	_16.48s	_16.64s	_{p=0.198 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.11s (± 0.31%)}	_{20.18s (± 0.33%)}	_~	_20.07s	_20.24s	_{p=0.127 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,225k (± 0.01%)}	_{512,213k (± 0.01%)}	_~	_512,158k	_512,271k	_{p=0.521 n=6}
_{Parse Time}	_{3.26s (± 0.13%)}	_{3.26s (± 0.17%)}	_~	_3.25s	_3.26s	_{p=0.054 n=6}
_{Bind Time}	_{1.55s (± 0.41%)}	_{1.55s (± 0.00%)}	_~	_1.55s	_1.55s	_{p=1.000 n=6}
_{Check Time}	_{2.78s (± 0.49%)}	_{2.78s (± 0.43%)}	_~	_2.77s	_2.80s	_{p=1.000 n=6}
_{Emit Time}	_{0.08s (± 7.90%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{7.67s (± 0.18%)}	_{7.66s (± 0.21%)}	_~	_7.64s	_7.68s	_{p=0.182 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,401ms (± 1.15%)}	_{2,361ms (± 1.71%)}	_~	_2,316ms	_2,412ms	_{p=0.093 n=6}
_{Req 2 - geterr}	_{5,281ms (± 1.13%)}	_{5,328ms (± 1.64%)}	_~	_5,227ms	_5,427ms	_{p=0.575 n=6}
_{Req 3 - references}	_{328ms (± 0.89%)}	_{330ms (± 1.29%)}	_~	_326ms	_335ms	_{p=0.805 n=6}
_{Req 4 - navto}	_{277ms (± 0.53%)}	_{276ms (± 0.48%)}	_~	_274ms	_277ms	_{p=0.197 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 4.52%)}	_{83ms (± 5.40%)}	_~	_78ms	_89ms	_{p=0.492 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,481ms (± 0.42%)}	_{2,476ms (± 1.22%)}	_~	_2,417ms	_2,498ms	_{p=0.688 n=6}
_{Req 2 - geterr}	_{4,067ms (± 1.37%)}	_{4,092ms (± 1.74%)}	_~	_4,040ms	_4,197ms	_{p=0.575 n=6}
_{Req 3 - references}	_{334ms (± 0.31%)}	_{337ms (± 1.17%)}	_~	_333ms	_342ms	_{p=0.560 n=6}
_{Req 4 - navto}	_{282ms (± 0.54%)}	_{282ms (± 0.48%)}	_~	_280ms	_283ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 3.41%)}	_{79ms (± 9.46%)}	_~	_72ms	_88ms	_{p=0.209 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,598ms (± 0.78%)}	_{2,600ms (± 0.92%)}	_~	_2,562ms	_2,631ms	_{p=0.872 n=6}
_{Req 2 - geterr}	_{1,687ms (± 2.12%)}	_{1,681ms (± 2.17%)}	_~	_1,628ms	_1,727ms	_{p=0.810 n=6}
_{Req 3 - references}	_{112ms (± 8.51%)}	_{116ms (± 8.89%)}	_~	_105ms	_126ms	_{p=0.572 n=6}
_{Req 4 - navto}	_{367ms (± 1.51%)}	_{364ms (± 0.21%)}	_~	_363ms	_365ms	_{p=0.103 n=6}
_{Req 5 - completionInfo count}	_{2,071 (± 0.00%)}	_{2,071 (± 0.00%)}	_~	_2,071	_2,071	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{306ms (± 1.40%)}	_{308ms (± 2.10%)}	_~	_298ms	_316ms	_{p=0.419 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{151.70ms (± 0.16%)}	_{151.63ms (± 0.22%)}	_{-0.08ms (- 0.05%)}	_150.60ms	_160.99ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{226.88ms (± 0.14%)}	_{226.58ms (± 0.15%)}	_{-0.31ms (- 0.14%)}	_225.52ms	_232.65ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.10ms (± 0.16%)}	_{228.11ms (± 0.19%)}	_~	_226.36ms	_235.08ms	_{p=0.462 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.91ms (± 0.15%)}	_{227.92ms (± 0.17%)}	_~	_226.40ms	_234.11ms	_{p=0.795 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2023-09-15T23:20:55Z

@typescript-bot run dt

typescript-bot · 2023-09-15T23:20:57Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at db28e0c. You can monitor the build here.

typescript-bot · 2023-09-16T00:33:14Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53681/merge:

Everything looks good!

typescript-bot · 2023-09-16T00:55:30Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53681/merge:

Everything looks good!

jakebailey · 2023-09-16T05:19:19Z

@typescript-bot run dt

typescript-bot · 2023-09-16T05:19:22Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at db28e0c. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-09-16T06:49:10Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

joscha · 2023-09-18T21:21:04Z

Well done @Andarist, thank you!

…soft#53681)

Narrow by clause expressions in switches with true condition

326098b

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 5, 2023

j-f1 mentioned this pull request Apr 16, 2023

Add a handler for AxiosError errors actualbudget/actual-server#189

Merged

sandersn requested review from weswigham and jakebailey April 18, 2023 23:07

sandersn assigned weswigham Apr 18, 2023

Andarist commented Apr 19, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into narrow-switch-true

7bff88a

Merge remote-tracking branch 'origin/main' into narrow-switch-true

db28e0c

jakebailey approved these changes Sep 15, 2023

View reviewed changes

jakebailey merged commit 70b7de1 into microsoft:main Sep 18, 2023
19 checks passed

snovader pushed a commit to mestro-se/TypeScript that referenced this pull request Sep 23, 2023

Narrow by clause expressions in switches with true condition (micro…

a4c53f6

…soft#53681)

DanielRosenwasser mentioned this pull request Oct 5, 2023

Narrowing switch(true) doesnt work for default case and is wrong for fallthrough cases in 5.3 #55986

Closed

Narrow by clause expressions in switches with true condition #53681

Narrow by clause expressions in switches with true condition #53681

Conversation

Andarist commented Apr 5, 2023

typescript-bot commented Apr 5, 2023

fatcerberus commented Apr 6, 2023

codingedgar commented Apr 6, 2023 • edited Loading

fatcerberus commented Apr 6, 2023

jakebailey commented Apr 18, 2023

jakebailey commented Apr 18, 2023

Andarist commented Apr 18, 2023

Andarist Apr 19, 2023

Choose a reason for hiding this comment

Andarist Sep 11, 2023

Choose a reason for hiding this comment

jakebailey commented Aug 29, 2023

typescript-bot commented Aug 29, 2023 • edited Loading

typescript-bot commented Aug 29, 2023

Compiler

tsserver

Startup

Andarist commented Sep 11, 2023

jakebailey commented Sep 15, 2023

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 15, 2023 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Sep 15, 2023

typescript-bot commented Sep 15, 2023

typescript-bot commented Sep 15, 2023

Compiler

tsserver

Startup

jakebailey commented Sep 15, 2023

typescript-bot commented Sep 15, 2023 • edited Loading

typescript-bot commented Sep 16, 2023

typescript-bot commented Sep 16, 2023

jakebailey commented Sep 16, 2023

typescript-bot commented Sep 16, 2023 • edited Loading

typescript-bot commented Sep 16, 2023

joscha commented Sep 18, 2023

Narrow by clause expressions in switches with `true` condition #53681

Narrow by clause expressions in switches with `true` condition #53681

codingedgar commented Apr 6, 2023 •

edited

Loading

typescript-bot commented Aug 29, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 15, 2023 •

edited

Loading

typescript-bot commented Sep 16, 2023 •

edited

Loading