Add a handler for AxiosError errors #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-f1
commented
Apr 16, 2023
| @@ -199,6 +200,16 @@ app.post( | |||
| error_code: 'NORDIGEN_ERROR', | |||
| }); | |||
| break; | |||
| case isAxiosError(error): | |||
There was a problem hiding this comment.
Fun fact! This doesn’t actually narrow the error type away from any. Maybe microsoft/TypeScript#53681 will fix that?
MatissJanis
approved these changes
Apr 17, 2023
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help debug more clearly when Nordigen’s API returns unexpected status codes, since the current shape causes the actual response data to be collapsed in the console logs.