Filtered out types from import suggestions in JS files

src/services/completions.ts

@@ -2084,6 +2084,11 @@ export function getCompletionEntriesFromSymbols(
             continue;
         }
 
+        // When in a value-time location in a JS file, ignore symbols that definitely seem to be type-only
+        if (!isTypeOnlyLocation && isInJSFile(sourceFile) && !symbolMayHaveValueDeclaration(symbol)) {
+            continue;
+        }
+
         const { name, needsConvertPropertyAccess } = info;
         const originalSortText = symbolToSortTextMap?.[getSymbolId(symbol)] ?? SortText.LocationPriority;
         const sortText = (isDeprecated(symbol, typeChecker) ? SortText.Deprecated(originalSortText) : originalSortText);
@@ -2180,6 +2185,23 @@ export function getCompletionEntriesFromSymbols(
     }
 }
 
+/**
+ * When filling completions for value-time locations in JS files, we'll want
+ * to only consider symbols that seem to have a value declaration. If a
+ * symbol no known declarations we cautiously include them just to be safe.
+ */
+function symbolMayHaveValueDeclaration(symbol: Symbol): boolean {
+    return !symbol?.declarations?.length || symbol.declarations.some(declaration => {
+        switch (declaration.kind) {
+            case SyntaxKind.InterfaceDeclaration:
+            case SyntaxKind.TypeAliasDeclaration:
+                return false;
+            default:
+                return true;
+        }
+    });
+}
+
 function getLabelCompletionAtPosition(node: BreakOrContinueStatement): CompletionInfo | undefined {
     const entries = getLabelStatementCompletions(node);
     if (entries.length) {

tests/baselines/reference/jsFileImportNoTypes.baseline

@@ -0,0 +1,264 @@
+=== /a.js ===
+// import {  } from './declarations.ts'
+//          ^
+// | ----------------------------------------------------------------------
+// | class DeclaredClass
+// | const declaredVariable: number
+// | class TestClass
+// | class TestClassInterfaceMerged
+// | interface TestClassInterfaceMerged
+// | enum TestEnum
+// | function testFunction(): void
+// | namespace TestNamespace
+// | const testValue: {}
+// | ----------------------------------------------------------------------
+
+[
+  {
+    "marker": {
+      "fileName": "/a.js",
+      "position": 9,
+      "name": ""
+    },
+    "item": {
+      "flags": 0,
+      "isGlobalCompletion": false,
+      "isMemberCompletion": true,
+      "isNewIdentifierLocation": false,
+      "entries": [
+        {
+          "name": "DeclaredClass",
+          "kind": "class",
+          "kindModifiers": "export,declare",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "class",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "DeclaredClass",
+              "kind": "className"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "declaredVariable",
+          "kind": "const",
+          "kindModifiers": "export,declare",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "const",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "declaredVariable",
+              "kind": "localName"
+            },
+            {
+              "text": ":",
+              "kind": "punctuation"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "number",
+              "kind": "keyword"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "TestClass",
+          "kind": "class",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "class",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "TestClass",
+              "kind": "className"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "TestClassInterfaceMerged",
+          "kind": "class",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "class",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "TestClassInterfaceMerged",
+              "kind": "className"
+            },
+            {
+              "text": "\n",
+              "kind": "lineBreak"
+            },
+            {
+              "text": "interface",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "TestClassInterfaceMerged",
+              "kind": "className"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "TestEnum",
+          "kind": "enum",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "enum",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "TestEnum",
+              "kind": "enumName"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "testFunction",
+          "kind": "function",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "function",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "testFunction",
+              "kind": "functionName"
+            },
+            {
+              "text": "(",
+              "kind": "punctuation"
+            },
+            {
+              "text": ")",
+              "kind": "punctuation"
+            },
+            {
+              "text": ":",
+              "kind": "punctuation"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "void",
+              "kind": "keyword"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "TestNamespace",
+          "kind": "module",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "namespace",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "TestNamespace",
+              "kind": "moduleName"
+            }
+          ],
+          "documentation": []
+        },
+        {
+          "name": "testValue",
+          "kind": "const",
+          "kindModifiers": "export",
+          "sortText": "11",
+          "displayParts": [
+            {
+              "text": "const",
+              "kind": "keyword"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "testValue",
+              "kind": "localName"
+            },
+            {
+              "text": ":",
+              "kind": "punctuation"
+            },
+            {
+              "text": " ",
+              "kind": "space"
+            },
+            {
+              "text": "{",
+              "kind": "punctuation"
+            },
+            {
+              "text": "}",
+              "kind": "punctuation"
+            }
+          ],
+          "documentation": []
+        }
+      ]
+    }
+  }
+]

tests/cases/fourslash/jsFileImportNoTypes.ts

@@ -0,0 +1,28 @@
+/// <reference path="fourslash.ts" />
+
+// @allowJs: true
+
+// @filename: /declarations.ts
+//// export class TestClass {}
+//// export const testValue = {};
+//// export enum TestEnum {}
+//// export function testFunction() {}
+//// export interface testInterface {}
+//// export namespace TestNamespace {}
+//// export type testType = {};
+////
+//// export interface TestInterfaceMerged {}
+//// export interface TestInterfaceMerged {}
+////
+//// export interface TestClassInterfaceMerged {}
+//// export class TestClassInterfaceMerged {}
+////
+//// export declare const declaredVariable: number;
+//// export declare class DeclaredClass {}
+//// export declare interface DeclaredInterface {}
+//// export declare type DeclaredType = {};
+
+// @filename: /a.js
+////import { /**/ } from './declarations.ts'
+
+verify.baselineCompletions();