Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtered out types from import suggestions in JS files #53619

Merged
merged 19 commits into from
Nov 16, 2023
Merged

Filtered out types from import suggestions in JS files #53619

merged 19 commits into from
Nov 16, 2023

Conversation

JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 1, 2023 •
edited
Loading

When in a JS file (with the exception of JSDoc type imports), type-only declarations (interfaces and type aliases) are filtered out of completion entries.

Fixes #53339

Co-authored-by: Mateusz Burzyński [email protected]

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 1, 2023
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 1, 2023 02:35
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 5, 2023 20:29
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 6, 2023 12:01
@JoshuaKGoldberg JoshuaKGoldberg requested a review from Andarist April 7, 2023 15:10
@sandersn sandersn requested a review from navya9singh April 12, 2023 20:20
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the no-types-in-esm-imports branch from 1a16619 to dd9ff9b Compare April 13, 2023 15:37
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft April 13, 2023 15:38
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 13, 2023 16:16
sandersn
sandersn requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I had a couple of questions about the tests.

src/testRunner/unittests/tsserver/completions.ts Show resolved Hide resolved
tests/cases/fourslash/jsFileImportNoTypes.ts Outdated Show resolved Hide resolved
sandersn
sandersn requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple more things about symbolAppearsToBeTypeOnly

src/services/completions.ts Outdated Show resolved Hide resolved
@sandersn sandersn merged commit 361fafb into microsoft:main Nov 16, 2023
19 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-types-in-esm-imports branch November 16, 2023 20:12
This was referenced Nov 16, 2023
Closed
Merged
@jasonlyu123 jasonlyu123 mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andarist Andarist Andarist left review comments

@sandersn sandersn sandersn approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@navya9singh navya9singh Awaiting requested review from navya9singh

Assignees

@navya9singh navya9singh

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out types from esm import suggestions in JavaScript
6 participants
@JoshuaKGoldberg @sandersn @RyanCavanaugh @Andarist @typescript-bot @navya9singh