Sort @deprecated completions lower than others

[sangxxh]

Fixes #43796

[sangxxh]

Sorry, where can I write tests for the session?

I've tried verify.completions but it's not testing this method in Session.

[sangxxh]

There's "something" in VSCode that's still re-ordering the suggestions. Debugging https://github.com/microsoft/vscode/tree/main/extensions/typescript-language-features shows that the server response looks correct:

But the suggestions shown to the UI differs, b is not at bottom:

Test Code:

const foo = {
  /**
   * @deprecated
   */
  b: 'b',
  a: 'a',
  c: 'c',
};

foo.

Trace when trigger completions in VSCode

[Trace  - 11:25:06.7] <semantic> Sending request: quickinfo (36). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "d:/typescript/deprecated.ts",
    "line": 10,
    "offset": 5
}
[Trace  - 11:25:06.7] <semantic> Response received: quickinfo (36). Request took 0 ms. Success: false . Message: No content available.
[Trace  - 11:25:06.309] <semantic> Sending request: completionInfo (37). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "d:/typescript/deprecated.ts",
    "line": 10,
    "offset": 5,
    "includeExternalModuleExports": true,
    "includeInsertTextCompletions": true
}
[Trace  - 11:25:06.314] <semantic> Response received: completionInfo (37). Request took 5 ms. Success: true 
Result: {
    "isGlobalCompletion": false,
    "isMemberCompletion": true,
    "isNewIdentifierLocation": false,
    "entries": [
        {
            "name": "a",
            "kind": "property",
            "kindModifiers": "",
            "sortText": "1"
        },
        {
            "name": "c",
            "kind": "property",
            "kindModifiers": "",
            "sortText": "1"
        },
        {
            "name": "b",
            "kind": "property",
            "kindModifiers": "deprecated",
            "sortText": "1"
        }
    ]
}
[Trace  - 11:25:06.333] <semantic> Sending request: completionEntryDetails (38). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "d:/typescript/deprecated.ts",
    "line": 10,
    "offset": 5,
    "entryNames": [
        "a"
    ]
}
[Trace  - 11:25:06.335] <semantic> Response received: completionEntryDetails (38). Request took 3 ms. Success: true 
Result: [
    {
        "name": "a",
        "kindModifiers": "",
        "kind": "property",
        "displayParts": [
            {
                "text": "(",
                "kind": "punctuation"
            },
            {
                "text": "property",
                "kind": "text"
            },
            {
                "text": ")",
                "kind": "punctuation"
            },
            {
                "text": " ",
                "kind": "space"
            },
            {
                "text": "a",
                "kind": "propertyName"
            },
            {
                "text": ":",
                "kind": "punctuation"
            },
            {
                "text": " ",
                "kind": "space"
            },
            {
                "text": "string",
                "kind": "keyword"
            }
        ],
        "documentation": [],
        "tags": []
    }
]

[Kingwl]

May we add more behavior about the order of completion item?

We have #40079 (to fix #40078) sometime ago.

It's seems very helpful for user experience.

BTW: No need to do in this PR.

/cc: @DanielRosenwasser @RyanCavanaugh

[sheetalkamat]

If the issue is committed (its still suggestion and not scheduled for milestone nor in backlog), this isn't right way to fix but instead to update sortText property with new enum value.

[DanielRosenwasser]

CC @uniqueiniquity @jessetrinity

[sheetalkamat]

There seems to be another PR #43880 doing this same thing

[sangxxh]

Ah, do we create overriding PRs just like that 😬