Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort @deprecated completions lower than others #43796

Closed
DanielRosenwasser opened this issue Apr 23, 2021 · 0 comments · Fixed by #43880
Closed

Sort @deprecated completions lower than others #43796

DanielRosenwasser opened this issue Apr 23, 2021 · 0 comments · Fixed by #43880
Labels
Committed The team has roadmapped this issue Domain: Completion Lists The issue relates to showing completion lists in an editor Fix Available A PR has been opened for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

If we do #43710, the first thing you'll see every time you request completions on a string is a bunch of crossed-out properties. Ideally, we never would've shown these properties anyway, but we traditionally had to have them there because ES6.

Originally posted by @DanielRosenwasser in #43710 (comment)

__

@deprecated has its own NodeFlags entry right now, so you just have to use the rules from the checker to decide if the signature as a whole should be considered deprecated (basically, whether all the signature's declarations are deprecated). I don't know the sort order code but I assume it would be easy.

Originally posted by @sandersn in #43710 (comment)

@DanielRosenwasser DanielRosenwasser added Domain: Completion Lists The issue relates to showing completion lists in an editor In Discussion Not yet reached consensus Suggestion An idea for TypeScript labels Apr 23, 2021
@DanielRosenwasser DanielRosenwasser added Good First Issue Well scoped, documented and has the green light Help Wanted You can do this labels Apr 23, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.4.0 milestone Apr 28, 2021
@DanielRosenwasser DanielRosenwasser added the Committed The team has roadmapped this issue label Apr 28, 2021
@sandersn sandersn removed the In Discussion Not yet reached consensus label Apr 29, 2021
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Committed The team has roadmapped this issue Domain: Completion Lists The issue relates to showing completion lists in an editor Fix Available A PR has been opened for this issue Good First Issue Well scoped, documented and has the green light Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
4 participants