fix(31046): more accurate error message when derived class has different constructor signature #40073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
requested changes
Aug 19, 2020
...baselines/reference/assignmentCompatWithConstructSignaturesWithOptionalParameters.errors.txt
Outdated
Show resolved
Hide resolved
|
Definitely looks like an improvement to me! |
typescript-bot
added
the
For Milestone Bug
Kingwl
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Aug 24, 2020
Kingwl
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Aug 24, 2020
sandersn
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Add see tag parser * add baseline * fix symbol resolve * add more case * fix unittests * improve tests and parser * accept baseline * Adopt package-lock.json and npm ci * Add a workflow to update package-lock.json daily * Git ignore package-lock.json and forcibly update in workflow * Update bot email address * Delete extra npm update * Update package-lock.json * Add compactDisplay and signDisplay to NumberFormatOptions (#40039) * Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176) * fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684) * fix(25770): add diagnostic message for the possible mapped type used as an index (#39973) * fix(31046): add new diagnostic message for incompatible constructor signature (#40073) * Update package-lock.json * Update package-lock.json * Add rename support * Accpet baseline * wip * fix anders * Revert "fix anders" This reverts commit b3178d4. * Fix call hierarchy item serialization and server tests (#40348) * Avoid error * accept baseline * Add more tests * Add signature name resolve Co-authored-by: Andrew Casey <[email protected]> Co-authored-by: TypeScript Bot <[email protected]> Co-authored-by: Neil Kistner <[email protected]> Co-authored-by: cherryblossom000 <[email protected]> Co-authored-by: Alexander T <[email protected]> Co-authored-by: Erich Gamma <[email protected]> Co-authored-by: Andrew Branch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31046
Fixes #21253