Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(26325): tsc emits invalid code for class expression assigned to a reserved word property #39684

Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix(26325): tsc emits invalid code for class expression assigned to a reserved word property #39684

merged 1 commit into from
Aug 21, 2020

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Jul 21, 2020 •
edited
Loading

Fixes #26325

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 8, 2020
DanielRosenwasser
DanielRosenwasser approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test file is a little....lengthy. I'd personally limit it to a few cases. But otherwise the change looks good.

@a-tarasyuk
Copy link
Contributor Author

@DanielRosenwasser I just tried to handle as much as possible cases with the keywords. If it bad I can cut the test to a couple of keywords. :)

weswigham
weswigham approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test length is fine - not all keywords behave alike, after all.

@DanielRosenwasser DanielRosenwasser merged commit 6ec3629 into microsoft:master Aug 21, 2020
Kingwl pushed a commit to Kingwl/TypeScript that referenced this pull request Aug 24, 2020
@a-tarasyuk @Kingwl
fix(26325): use a unique name for reserved words in 'constructor like…
85501e6 
…' function name (microsoft#39684)
Kingwl pushed a commit to Kingwl/TypeScript that referenced this pull request Aug 24, 2020
@a-tarasyuk @Kingwl
fix(26325): use a unique name for reserved words in 'constructor like…
282c38d 
…' function name (microsoft#39684)
sandersn pushed a commit that referenced this pull request Sep 9, 2020
@Kingwl @amcasey
@typescript-bot @wyze @cherryblossom000 @a-tarasyuk @egamma @andrewbranch
Add see tag support (#39760)
ee5f51b 
* Add see tag parser

* add baseline

* fix symbol resolve

* add more case

* fix unittests

* improve tests and parser

* accept baseline

* Adopt package-lock.json and npm ci

* Add a workflow to update package-lock.json daily

* Git ignore package-lock.json and forcibly update in workflow

* Update bot email address

* Delete extra npm update

* Update package-lock.json

* Add compactDisplay and signDisplay to NumberFormatOptions (#40039)

* Fix typo in (Readonly)Set.keys comment (fixes #40164) (#40176)

* fix(26325): use a unique name for reserved words in 'constructor like' function name (#39684)

* fix(25770): add diagnostic message for the possible mapped type used as an index (#39973)

* fix(31046): add new diagnostic message for incompatible constructor signature (#40073)

* Update package-lock.json

* Update package-lock.json

* Add rename support

* Accpet baseline

* wip

* fix anders

* Revert "fix anders"

This reverts commit b3178d4.

* Fix call hierarchy item serialization and server tests (#40348)

* Avoid error

* accept baseline

* Add more tests

* Add signature name resolve

Co-authored-by: Andrew Casey <[email protected]>
Co-authored-by: TypeScript Bot <[email protected]>
Co-authored-by: Neil Kistner <[email protected]>
Co-authored-by: cherryblossom000 <[email protected]>
Co-authored-by: Alexander T <[email protected]>
Co-authored-by: Erich Gamma <[email protected]>
Co-authored-by: Andrew Branch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@weswigham weswigham

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsc emits invalid code for class expression assigned to a reserved word property
4 participants
@a-tarasyuk @DanielRosenwasser @weswigham @typescript-bot