Allow --composite false or --composite null on the command line #36997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
RyanCavanaugh,
weswigham and
DanielRosenwasser
weswigham
reviewed
Feb 25, 2020
…ly end result from our config file as well
weswigham
reviewed
Feb 25, 2020
weswigham
reviewed
Feb 26, 2020
|
@weswigham @RyanCavanaugh good to go? I assume we want this in 3.8.3 |
|
@typescript-bot cherry-pick this to release-3.8 branch |
|
Heya @sheetalkamat, I've started to run the task to cherry-pick this into |
sheetalkamat
changed the title
|
Hey @sheetalkamat, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.8 manually. |
weswigham
reviewed
Feb 26, 2020
RyanCavanaugh
approved these changes
Feb 26, 2020
sheetalkamat
added a commit
that referenced
this pull request
Feb 26, 2020
* Add tests for specifying composite as command line option * Allow passing --composite false on commandline * Add test to verify tsc --composite false from command line * Handle "undefined" as option value to be set to undefined for that option * Support "null" as option to be converted to undefined which is normally end result from our config file as well * Support null as option for any tsconfig only option as well, and dont support undefined * Fix public api test case * Validates objects instead of stringify result * Add composite true to base source
sheetalkamat
added a commit
that referenced
this pull request
Feb 27, 2020
…) (#37062) * Add tests for specifying composite as command line option * Allow passing --composite false on commandline * Add test to verify tsc --composite false from command line * Handle "undefined" as option value to be set to undefined for that option * Support "null" as option to be converted to undefined which is normally end result from our config file as well * Support null as option for any tsconfig only option as well, and dont support undefined * Fix public api test case * Validates objects instead of stringify result * Add composite true to base source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running typecheck only builds on composite projects and handles #36917