-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tsconfig): allow null on tsBuildInfoFile #3367
Conversation
Please tell me if I am misunderstanding, but the linked issue seems to state that |
The linked PR adds support for passing this option via the command line, but it also works in tsconfig. Check out this experiment: https://codespaces.new/wtchnm/3367 or https://github.com/wtchnm/3367. |
Thank you for the link. It appears that the value is valid and is parsed, but unfortunately, the option is not documented. I checked the tsconfig and cli reference, but it was not mentioned. This repository has a policy of requiring all features in the schema to be documented. More information at this link. |
I have opened #3372 because I disagree with the "policy" and want to merge changes like this. Once everyone is on the same page, and it is accepted, then I will happily merge your contributings. The PR will need to be modified to add a |
@wtchnm I got the go-ahead for this change. I'll merge this once you add a |
Thanks @hyperupcall! I added the "$comment" in both cases. |
thanks! |
Related to 1602f19 (SchemaStore#3367).
* Allow null in tsconfig.json Related to 1602f19 (#3367). * Document where TypeScript started allowing null in tsconfig.json * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
See microsoft/TypeScript#38493