Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsconfig): allow null on tsBuildInfoFile #3367

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix(tsconfig): allow null on tsBuildInfoFile #3367

merged 2 commits into from
Nov 8, 2023

Conversation

wtchnm
Copy link
Contributor

@wtchnm wtchnm commented Nov 3, 2023

@hyperupcall
Copy link
Member

Please tell me if I am misunderstanding, but the linked issue seems to state that null is only available on the command line, as per microsoft/TypeScript#36997?

@wtchnm
Copy link
Contributor Author

wtchnm commented Nov 6, 2023

The linked PR adds support for passing this option via the command line, but it also works in tsconfig. Check out this experiment: https://codespaces.new/wtchnm/3367 or https://github.com/wtchnm/3367.

@hyperupcall
Copy link
Member

Thank you for the link. It appears that the value is valid and is parsed, but unfortunately, the option is not documented. I checked the tsconfig and cli reference, but it was not mentioned.

This repository has a policy of requiring all features in the schema to be documented. More information at this link.

@hyperupcall
Copy link
Member

hyperupcall commented Nov 6, 2023

I have opened #3372 because I disagree with the "policy" and want to merge changes like this. Once everyone is on the same page, and it is accepted, then I will happily merge your contributings. The PR will need to be modified to add a $comment that "null" is not documented.

@hyperupcall
Copy link
Member

@wtchnm I got the go-ahead for this change. I'll merge this once you add a $comment in both cases, saying that the value of null is UNDOCUMENTED (please capitalize UNDOCUMENTED so all undocumented instances are easy to search for). Thanks

@wtchnm
Copy link
Contributor Author

wtchnm commented Nov 8, 2023

Thanks @hyperupcall! I added the "$comment" in both cases.

@hyperupcall
Copy link
Member

thanks!

@hyperupcall hyperupcall merged commit 1602f19 into SchemaStore:master Nov 8, 2023
2 checks passed
@wtchnm wtchnm deleted the fix/tsbuildinfo-null branch November 8, 2023 14:03
denis-sokolov added a commit to denis-sokolov/schemastore that referenced this pull request Mar 26, 2024
madskristensen pushed a commit that referenced this pull request Mar 26, 2024
* Allow null in tsconfig.json

Related to 1602f19 (#3367).

* Document where TypeScript started allowing null in tsconfig.json

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants