Expose emitFiles #2418
Closed
Expose emitFiles #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the purpose of this? Why not just have people make a program instance and call .emit on that? |
|
There is no way to just emit a file that has been created outside a program. e.g. multiple files combined into one for instance. |
|
Why are you emitting a file created outside of a program? If you want to do that, just make a program containing that single file and call .emit on it. In order to emit properly, we need to have the checker results (so we can do things like emit enum references properly). The entity that encapsulates all of this proper management of information and emitting is the Program itself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2217