Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose emitFiles in the public .d.ts #2217

Closed
mhegazy opened this issue Mar 6, 2015 · 2 comments
Closed

Expose emitFiles in the public .d.ts #2217

mhegazy opened this issue Mar 6, 2015 · 2 comments
Assignees
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Mar 6, 2015

If you want to make modifications to a tree and emit that, you are required to write your own emitter as emitFiles is not exposed in the public .d.ts file. tools like: https://github.com/sitepen/dts-generator would not be able to leverage the compiler API.

@mhegazy mhegazy added Bug A bug in TypeScript API Relates to the public API for TypeScript labels Mar 6, 2015
@mhegazy mhegazy self-assigned this Mar 6, 2015
@mhegazy mhegazy added this to the TypeScript 1.5 milestone Mar 6, 2015
@csnover
Copy link
Contributor

csnover commented Mar 6, 2015

Seems like Program#emit might work OK for our use case? Other things were removed entirely like createEmitHostFromProgram that were important to the old way, but if Program can do it directly, then we’re probably in good shape.

That said, there are some bugs in declaration emitting ES6 modules syntax (#2220 and #2221), so I’m waiting for those to be addressed before I can verify this.

@mhegazy
Copy link
Contributor Author

mhegazy commented Apr 14, 2015

since this is not needed any more, i will close it. @csnover please let us know if this is not the case.

@mhegazy mhegazy closed this as completed Apr 14, 2015
@mhegazy mhegazy added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label Apr 14, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants