Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyof tests to reflect #12425 #12533

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

ethanresnick
Copy link
Contributor

#12425 removed number from the union type constituting keyof T, but the comments in the test cases still had number as a possible type. This PR changes the comments in the tests so they match the actual behavior.

It also adds a test that numeric index signatures:

keyof NumericallyIndexed<Shape> // checks that this is never
type NumericallyIndexed<T> = { [x: number]: T };

Removes number from all the keyof types, and adds a test that numeric
indexes are ignored.
@msftclas
Copy link

Hi @ethanresnick, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@mhegazy mhegazy merged commit 9cac35b into microsoft:master Nov 28, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Nov 28, 2016

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
@ethanresnick ethanresnick deleted the keyof-tests branch October 10, 2019 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants