Change 'keyof T' to always be string-like #12425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhegazy Ping! |
mhegazy
approved these changes
Nov 21, 2016
ethanresnick
added a commit
to ethanresnick/TypeScript
that referenced
this pull request
Nov 27, 2016
Now that keyof T only returns string or string subtypes (microsoft#12425), there’s no need to do keyof T & string.
ethanresnick
added a commit
to ethanresnick/TypeScript
that referenced
this pull request
Nov 28, 2016
Removes number from all the keyof types, and adds a test that numeric indexes are ignored.
mhegazy
added a commit
that referenced
this pull request
Nov 28, 2016
Update keyof tests to reflect #12425
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises
keyof Tto always be a subtype ofstringvs. a subtype ofstring | number. This more accurately reflects how properties work in JavaScript and allows us to usekeyof Tas the inferred type of afor...invariable when the object is of a type parameter type.This change means that numeric index signatures are ignored by the
keyof Toperator and that it is never possible to use numbers as values for akeyof T.Fixes #12314.