Adjust twoslash inlay provider to use the new Monaco API for that #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Feb 16, 2022
| @@ -31,12 +39,15 @@ export const createTwoslashInlayProvider = (sandbox: Sandbox) => { | |||
| // @ts-ignore | |||
| kind: 0, | |||
| position: new sandbox.monaco.Position(endPos.lineNumber, endPos.column + 1), | |||
| text, | |||
| whitespaceBefore: true, | |||
| label: text, | |||
There was a problem hiding this comment.
this commit has changed text to label and also changed the return type of provideInlayHints:
microsoft/vscode@3677cc4
Andarist
commented
Feb 16, 2022
| text, | ||
| whitespaceBefore: true, | ||
| label: text, | ||
| paddingLeft: true, |
There was a problem hiding this comment.
this commit has changed whitespaceBefore to paddingLeft:
microsoft/vscode@8ef8933
orta
approved these changes
Feb 16, 2022
|
Merged as part of #2288. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2247
this PR is related to this one since it also updated Monaco: #2267
cc @orta