Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy URL to clipboard keyboard shortcut #2267

Closed
wants to merge 2 commits into from

Conversation

andrewbranch
Copy link
Member

I guess monaco changed their enum format 😕

@andrewbranch andrewbranch changed the title Update monaco typings and adjust Fix copy URL to clipboard keyboard shortcut Feb 15, 2022
@andrewbranch andrewbranch force-pushed the bug/fix-keyboard-shortcut branch from 098c5f6 to 868bd4f Compare February 15, 2022 00:36
@orta
Copy link
Contributor

orta commented Feb 15, 2022

Looks like legit CI fails from the Monaco update FWIW

That said, this change:

Error: ➤ YN0000: [@typescript/playground]: src/twoslashInlays.ts(5,5): error TS2322: Type '(model: ITextModel, _: Range, cancel: CancellationToken) => Promise<InlayHint[]>' is not assignable to type '(model: ITextModel, range: Range, token: CancellationToken) => ProviderResult'.

Is a tricky problem to de-tangle because of #2247 - if you change the API usage then doing // ^? will crash (the BG thread) on the current and older TypeScript builds.

I think this change should probably happen post 4.6 and we only support the twoslash queries on 4.6 with the new inlayformat shape which that compiler error notes.

@andrewbranch
Copy link
Member Author

Yeah, I realized that when I went to start fixing those CI errors. I might just hack the keyboard fix without the typings update for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants