fix: jsx is undefined by default, not preserve or react
#1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one gets an error when using JSX without configuring `jsx`: `error TS17004: Cannot use JSX unless the '--jsx' flag is provided.` - TSConfig Reference said default was `react`, which is inaccurate - Compiler Options said default was `preserve`, which is also inaccurate - Add a `undefined` as the default in TSConfig Reference, same as allowUnrechableCode - Remove the default in Compiler Options, same as all the other options without defaults ---- History: Reference: - `preserve` was written as the default in microsoft@eae5cc3#diff-444415c73770eafd0f9db7d708d74131R5 - But then was written as `react` in the body in microsoft@eae5cc3#diff-444415c73770eafd0f9db7d708d74131R5 - It was then switched to `react` in microsoft@450ae96#diff-a912c6af3a16bf4288093c1264955bc6R120 - And then removed in microsoft@76b7d43#diff-a912c6af3a16bf4288093c1264955bc6L120 Compiler Options: - `preserve` was written as the default in microsoft@66f17ad#diff-bfc78b96c15b0ee906c1ab6176546dceR41
|
|
This was referenced Sep 17, 2020
|
I think wiping the string is 👍🏻 - this one also hit the CLA ( maybe it's on the size of the PR?) - good to go if you accept it |
|
CLA accepted. 🤷 didn't really see a pattern to why it chose this and #1111 to ask, sounds like a potential bug in the CLA checker 😬 |
|
Yeah, I'm not sure I want to look behind the curtain of the wizard of CLA - thanks, this is super useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
one gets an error when using JSX without configuring
jsx:error TS17004: Cannot use JSX unless the '--jsx' flag is provided.TSConfig Reference said default was
react, which is inaccurateCompiler Options said default was
preserve, which is also inaccurateAdd a
undefinedas the default in TSConfig Reference, same asallowUnrechableCode
Remove the default in Compiler Options, same as all the other options
without defaults
History:
Reference:
preservewas written as the default in eae5cc3#diff-444415c73770eafd0f9db7d708d74131R5 / TSConfig Reference Overview #103 herereactin the body in eae5cc3#diff-444415c73770eafd0f9db7d708d74131R5 / Move over some of the new handbook TSConfig docs #119 herereactin 450ae96#diff-a912c6af3a16bf4288093c1264955bc6R120 / Improve the JSX docs #861 hereCompiler Options:
preservewas written as the default in 66f17ad#diff-bfc78b96c15b0ee906c1ab6176546dceR41Tags
Similar to #1101 , found while investigating discrepancies between the TSConfig Reference and Compiler Options after finding #1092
See historical references above as well
Review Notes
Can remove the
undefineddefault and just have nothing instead in the Reference. Wasn't sure if I should matchallowUnreachableCodeor if that were an exception sinceundefinedmeans something else there.