fix: allowUnreachableCode default should be undefined #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it was recently changed to undefined in the TSConfig Reference in ea8407c - this carries over that change to the Compiler Options docs as well - and it being undefined seems to align with my past experience with unreachable code in TS, but have not tested directly recently
This was referenced Sep 17, 2020
|
Agree - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it was recently changed to undefined in the TSConfig Reference in
ea8407c
and it being undefined seems to align with my past experience with
unreachable code in TS, but have not tested directly recently
Tags
Found while investigating discrepancies between the TSConfig Reference and Compiler Options after finding #1092
This goes along with the changes to the Reference in #776