Skip to content

Commit

Permalink
fix: add missing inverses in relatedTo (#1099)
Browse files Browse the repository at this point in the history
- one side of the relationship existed but not the other side, ensure
  both sides of the relationship are relatedTo each other for proper
  backlinking etc

- add a new line after all the strict options for proper grouping same
  as the other groups
  • Loading branch information
agilgur5 authored Sep 17, 2020
1 parent d1ff226 commit f30907a
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions packages/tsconfig-reference/scripts/tsconfigRules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ type AnOption = WatchProperties | RootProperties | CompilerOptionName;
/** Allows linking between options */
export const relatedTo: [AnOption, AnOption[]][] = [
["strict", ["alwaysStrict", "strictNullChecks", "strictBindCallApply", "strictFunctionTypes", "strictPropertyInitialization", "noImplicitAny", "noImplicitThis"]],
["alwaysStrict", ["strict"]],
["strictNullChecks", ["strict"]],
["strictBindCallApply", ["strict"]],
["strictFunctionTypes", ["strict"]],
["strictPropertyInitialization", ["strict"]],
["noImplicitAny", ["strict"]],
["noImplicitThis", ["strict"]],

["allowSyntheticDefaultImports", ["esModuleInterop"]],
["esModuleInterop", ["allowSyntheticDefaultImports"]],

Expand All @@ -66,21 +74,27 @@ export const relatedTo: [AnOption, AnOption[]][] = [

["importHelpers", ["noEmitHelpers", "downlevelIteration", "importHelpers"]],
["noEmitHelpers", ["importHelpers"]],
["downlevelIteration", ["importHelpers"]],

["incremental", ["composite", "tsBuildInfoFile"]],
["composite", ["incremental", "tsBuildInfoFile"]],
["tsBuildInfoFile", ["incremental", "composite"]],

["types", ["typeRoots"]],
["typeRoots", ["types"]],
["declaration", ["emitDeclarationOnly"]],

["noLib", ["lib"]],
["lib", ["noLib"]],

["allowJs", ["checkJs", "emitDeclarationOnly"]],
["checkJs", ["allowJs", "emitDeclarationOnly"]],
["declaration", ["declarationDir", "emitDeclarationOnly"]],
["declarationDir", ["declaration"]],
["emitDeclarationOnly", ["declaration"]],

["moduleResolution", ["module"]],
["module", ["moduleResolution"]],

["jsxFactory", ["jsxFragmentFactory"]],
["jsxFragmentFactory", ["jsxFactory"]],
Expand Down

0 comments on commit f30907a

Please sign in to comment.