Verify in vector::pop_back if _CONTAINER_DEBUG_LEVEL > 0 #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #586. |
StephanTLavavej
approved these changes
Aug 2, 2024
|
Thanks, this makes We merge PRs simultaneously to our GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely next week depending on how busy I am. I'll post comments here as I prepare to merge your PR! |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this enhancement and congratulations on your first microsoft/STL commit! 🥇 😻 🎉 This is expected to ship in VS 2022 17.12 Preview 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
_CONTAINER_DEBUG_LEVEL > 0instead of_ITERATOR_DEBUG_LEVEL == 2invector::pop_back. The former seems to be the better choice considering that there are no iterators involved here.