driver/Keysight N5245A #807

johnhornibrook · 2017-10-21T12:26:49Z

Driver for Keysight network analyzer N5245A

#778

@Dominik-Vogel
Also if @StevenWaddy @jana-d could put a quick eye on it that would be great

WilliamHPNielsen · 2017-12-06T09:54:29Z

@Dominik-Vogel @StevenWaddy Any verdict on this guy?

codecov · 2018-04-23T07:08:56Z

Codecov Report

Merging #807 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   79.96%   79.97%   +0.01%     
==========================================
  Files          49       49              
  Lines        6673     6678       +5     
==========================================
+ Hits         5336     5341       +5     
  Misses       1337     1337

johnhornibrook · 2018-05-16T09:11:24Z

@spauka is adding some changes for compatibility with the new dataset. We'll ping when ready.

jenshnielsen · 2018-07-20T08:29:19Z

@johnhornibrook @spauka Whats the status on this one? Would be nice to get it merged

spauka · 2018-07-22T02:28:29Z

This is ready by my reckoning. Tested on N5245A and N5230C and working :)

- Lots of trailing white space - rename variables - fix format string

jenshnielsen · 2018-07-23T07:41:59Z

qcodes/instrument_drivers/Keysight/N52xx.py

+        if self._instrument is None:
+            return (0,)
+        return (self._instrument.root_instrument.points(),)
+    @shape.setter


Do we need these do nothing setters? If we just leave them out setting the value will be an error. Like this it will just do nothing. Is that what we want?

Unfortunately if they are not included, then the super().__init__ call fails. It seemed simpler to create a blank setter than to reimplement the rest of the __init__ call? Although perhaps it's less clear, and it would be worth reimplementing it anyway...

Lets not spent to much time on it. But can you include a comment to mention that

jenshnielsen

Left some very minor comments inline. Would you be willing to add a notebook to the documentation showing how this driver works?

jenshnielsen · 2018-07-23T07:51:05Z

qcodes/instrument_drivers/Keysight/N52xx.py

+        Select correct trace before querying
+        """
+        super().write("CALC:PAR:MNUM {}".format(self.trace))
+        super().write(cmd)


please add a blank line here

jenshnielsen · 2018-07-23T07:51:36Z

qcodes/instrument_drivers/Keysight/N52xx.py

+        """
+        Extrace S_parameter from returned PNA format
+        """
+        return self.parse_paramstring(paramspec)[1]


jenshnielsen · 2018-07-23T08:05:00Z

qcodes/instrument_drivers/Keysight/N52xx.py

+                           label="power",
+                           unit="dBm",
+                           get_cmd=pow_cmd + "?",
+                           set_cmd=pow_cmd + "{}",


Should there be a whitespace between the pow_cmd and the value when setting like in the commands below.
I would personally find it clearer to write this as: get_cmd=f'{pow_cmd}?' and set_cmd=f'{pow_cmd} {{}}'

spauka · 2018-07-23T12:13:30Z

Agreed with all the above 😄 I've made the formatting changes, I'll put together a sample notebook tomorrow.

spauka · 2018-07-26T06:11:18Z

@jenshnielsen There is now an example notebook available:

https://github.com/johnhornibrook/Qcodes/blob/driver-n5245a/docs/examples/driver_examples/Qcodes_example_with_Keysight_Network_Analyzer.ipynb

Hopefully that resolves all outstanding issues?

astafan8 · 2018-07-26T08:47:22Z

qcodes/instrument_drivers/Keysight/N52xx.py

+
+        # Functions
+        # Clear averages
+        self.add_function('reset_averages',


Could you please convert all the add_functions to bound methods of the class which body contains self.write('SENS:AVER:CLE')? We are working on removing functions in favor of bound methods because apart from other things it brings clarity. @WilliamHPNielsen

Yep, done :)

astafan8 · 2018-07-26T08:51:29Z

qcodes/instrument_drivers/Keysight/N52xx.py

+        for param in trace1.parameters.values():
+            self.parameters[param.name] = param
+        # By default we should also pull any following values from this trace
+        self.write("CALC:PAR:MNUM 1")


similar command is used 2 times in the PNATrace class.

could you extract it as a separate method of PNATrace class?

could you re-use the extracted method here since you've created the trace1 object?

To address your concern, I wrapped this into a parameter, active_trace, and am writing this everywhere instead.

astafan8 · 2018-07-26T08:54:31Z

qcodes/instrument_drivers/Keysight/N52xx.py

+        # Set auto_sweep parameter
+        # If we want to return multiple traces per setpoint without sweeping
+        # multiple times, we should set this to false
+        self._auto_sweep = True


why do you wrap _auto_sweep into a parameter, or why do you have a private attribute AND a parameter? So far as I see, the following will work just fine without the need for _auto_sweep and _set_auto_sweep:

self.add_parameter('auto_sweep', label='Auto Sweep', set_cmd=None, get_cmd=None, vals=Bool(), initial_value=True)

Sure :)

I guess I haven't really seen any docs suggesting the best way to handle local parameters that should be cached? If this is the preferred way, I'm happy to go with it 👍

great!

well, Parameters are always cached: you can call get_latest to get the latest value of the parameter without accessing the instrument.

astafan8 · 2018-07-26T08:56:00Z

qcodes/instrument_drivers/Keysight/N52xx.py

+
+        # A default output format on initialisation
+        self.write('FORM REAL,32')
+        self.write('FORM:BORD NORM')


are these two commands not supposed to be called elsewhere/elsewhen? because if they might, please, make each of them a method (or a parameter, perhaps)?

This just sets the transfer format, I can't see any reason why they need to be called again or changed once set. There is no way to change their values in the UI, so it only needs to happen once when connecting...

Merge: f7b173f e9e13cf Author: Mikhail Astafev <[email protected]> Merge pull request #807 from johnhornibrook/driver-n5245a

4745: Update pyjwt requirement from ~=2.5.0 to ~=2.6.0 r=jenshnielsen a=dependabot[bot] Updates the requirements on [pyjwt](https://github.com/jpadilla/pyjwt) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst">pyjwt's changelog</a>.</em></p> <blockquote> <h2><code>v2.6.0 <https://github.com/jpadilla/pyjwt/compare/2.5.0...2.6.0></code>__</h2> <p>Changed</p> <pre><code> - bump up cryptography >= 3.4.0 by `@jpadilla` in `[#807](jpadilla/pyjwt#807) <https://github.com/jpadilla/pyjwt/pull/807>`_ - Remove `types-cryptography` from `crypto` extra by `@lautat` in `[#805](jpadilla/pyjwt#805) <https://github.com/jpadilla/pyjwt/pull/805>`_ <p>Fixed</p> <pre><code> - Invalidate token on the exact second the token expires `[#797](jpadilla/pyjwt#797) &lt;https://github.com/jpadilla/pyjwt/pull/797&gt;`_ - fix: version 2.5.0 heading typo by `@c0state` in `[#803](jpadilla/pyjwt#803) &lt;https://github.com/jpadilla/pyjwt/pull/803&gt;`_ Added </code></pre> <ul> <li>Adding validation for <code>issued_at</code> when <code>iat &gt; (now + leeway)</code> as <code>ImmatureSignatureError</code> by <a href="https://github.com/sriharan16"><code>`@sriharan16</code></a>` in <a href="https://github-redirect.dependabot.com/jpadilla/pyjwt/pull/794">jpadilla/pyjwt#794</a></li> </ul> <h2><code>v2.5.0 &lt;https://github.com/jpadilla/pyjwt/compare/2.4.0...2.5.0&gt;</code>__</h2> <p>Changed </code></pre></p> <ul> <li>Skip keys with incompatible alg when loading JWKSet by <a href="https://github.com/DaGuich"><code>`@DaGuich</code></a>` in <code>[#762](jpadilla/pyjwt#762) <https://github.com/jpadilla/pyjwt/pull/762></code>__</li> <li>Remove support for python3.6 by <a href="https://github.com/sirosen"><code>`@sirosen</code></a>` in <code>[#777](jpadilla/pyjwt#777) <https://github.com/jpadilla/pyjwt/pull/777></code>__</li> <li>Emit a deprecation warning for unsupported kwargs by <a href="https://github.com/sirosen"><code>`@sirosen</code></a>` in <code>[#776](jpadilla/pyjwt#776) <https://github.com/jpadilla/pyjwt/pull/776></code>__</li> <li>Remove redundant wheel dep from pyproject.toml by <a href="https://github.com/mgorny"><code>`@mgorny</code></a>` in <code>[#765](jpadilla/pyjwt#765) <https://github.com/jpadilla/pyjwt/pull/765></code>__</li> <li>Do not fail when an unusable key occurs by <a href="https://github.com/DaGuich"><code>`@DaGuich</code></a>` in <code>[#762](jpadilla/pyjwt#762) <https://github.com/jpadilla/pyjwt/pull/762></code>__</li> <li>Update audience typing by <a href="https://github.com/JulianMaurin"><code>`@JulianMaurin</code></a>` in <code>[#782](jpadilla/pyjwt#782) <https://github.com/jpadilla/pyjwt/pull/782></code>__</li> <li>Improve PyJWKSet error accuracy by <a href="https://github.com/JulianMaurin"><code>`@JulianMaurin</code></a>` in <code>[#786](jpadilla/pyjwt#786) <https://github.com/jpadilla/pyjwt/pull/786></code>__</li> <li>Mypy as pre-commit check + api_jws typing by <a href="https://github.com/JulianMaurin"><code>`@JulianMaurin</code></a>` in <code>[#787](jpadilla/pyjwt#787) <https://github.com/jpadilla/pyjwt/pull/787></code>__</li> </ul> <p>Fixed</p> <pre><code> - Adjust expected exceptions in option merging tests for PyPy3 by `@mgorny` in `[#763](jpadilla/pyjwt#763) <https://github.com/jpadilla/pyjwt/pull/763>`__ - Fixes for pyright on strict mode by `@brandon-leapyear` in `[#747](jpadilla/pyjwt#747) <https://github.com/jpadilla/pyjwt/pull/747>`__ - docs: fix simple typo, iinstance -> isinstance by `@timgates42` in `[#774](jpadilla/pyjwt#774) <https://github.com/jpadilla/pyjwt/pull/774>`__ - Fix typo: priot -> prior by `@jdufresne` in `[#780](jpadilla/pyjwt#780) <https://github.com/jpadilla/pyjwt/pull/780>`__ - Fix for headers disorder issue by `@kadabusha` in `[#721](jpadilla/pyjwt#721) <https://github.com/jpadilla/pyjwt/pull/721>`__ <p>Added </code></pre></p> <ul> <li>Add to_jwk static method to ECAlgorithm by <a href="https://github.com/leonsmith"><code>`@leonsmith</code></a>` in <code>[#732](jpadilla/pyjwt#732) <https://github.com/jpadilla/pyjwt/pull/732></code>__</li> <li>Expose get_algorithm_by_name as new method by <a href="https://github.com/sirosen"><code>`@sirosen</code></a>` in <code>[#773](jpadilla/pyjwt#773) <https://github.com/jpadilla/pyjwt/pull/773></code>__</li> <li>Add type hints to jwt/help.py and add missing types dependency by <a href="https://github.com/kkirsche"><code>`@kkirsche</code></a>` in <code>[#784](jpadilla/pyjwt#784) <https://github.com/jpadilla/pyjwt/pull/784></code>__</li> <li>Add cacheing functionality for JWK set by <a href="https://github.com/wuhaoyujerry"><code>`@wuhaoyujerry</code></a>` in <code>[#781](jpadilla/pyjwt#781) <https://github.com/jpadilla/pyjwt/pull/781></code>__</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jpadilla/pyjwt/commits">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 4746: Update pandas requirement from ~=1.5.0 to ~=1.5.1 r=jenshnielsen a=dependabot[bot] Updates the requirements on [pandas](https://github.com/pandas-dev/pandas) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/pandas-dev/pandas/releases">pandas's releases</a>.</em></p> <blockquote> <h2>Pandas 1.5.1</h2> <p>This is a patch release in the 1.5.x series and includes some regression and bug fixes. We recommend that all users upgrade to this version.</p> <p>See the <a href="https://pandas.pydata.org/pandas-docs/version/1.5.1/whatsnew/v1.5.1.html">full whatsnew</a> for a list of all the changes.</p> <p>The release will be available on the defaults and conda-forge channels:</p> <pre><code>conda install pandas </code></pre> <p>Or via PyPI:</p> <pre><code>python3 -m pip install --upgrade pandas </code></pre> <p>Please report any issues with the release on the <a href="https://github.com/pandas-dev/pandas/issues">pandas issue tracker</a>.</p> <p>Thanks to all the contributors who made this release possible.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pandas-dev/pandas/commit/91111fd99898d9dcaa6bf6bedb662db4108da6e6"><code>91111fd</code></a> RLS: 1.5.1</li> <li><a href="https://github.com/pandas-dev/pandas/commit/72863856504a4e906fc603f9e4624f251b614828"><code>7286385</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49162">#49162</a> on branch 1.5.x (PERF: Fix performance regression for isin...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/8429c50a279ba953514d1ca4d4a2bcef5e23ecc9"><code>8429c50</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49140">#49140</a> on branch 1.5.x (Revert "PERF: faster corrwith method for ...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/5b036c1c35890c44531f796f5dca92796276b2b5"><code>5b036c1</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49137">#49137</a> on branch 1.5.x (WEB/DOC: Fix typo in OVH name) (<a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49138">#49138</a>)</li> <li><a href="https://github.com/pandas-dev/pandas/commit/ea971acb948d16e284a38292cd615a5eb7c055ab"><code>ea971ac</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/48770">#48770</a> on branch 1.5.x (added sytle in stylesheet for <blockquote...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/27717a20061aaedda0d3e5de8461835e952c49f3"><code>27717a2</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49080">#49080</a> on branch 1.5.x (REGR: midx.values resetting freq of under...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/c58f2057b8c8a7fa79654c45a83c963c013a3aa3"><code>c58f205</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/48457">#48457</a> on branch 1.5.x (TST: Fix unsigned pyarrow types in SIGNED...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/072402b58cbd87c2106413a37213c0b6020e34b1"><code>072402b</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49053">#49053</a> on branch 1.5.x (REVERT caching in find_stack_level) (<a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49079">#49079</a>)</li> <li><a href="https://github.com/pandas-dev/pandas/commit/f9eebaf9de23aa9c5debdd86524615b22c23025f"><code>f9eebaf</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49072">#49072</a> on branch 1.5.x (BUG: redirect from meeting to community w...</li> <li><a href="https://github.com/pandas-dev/pandas/commit/b8d2f461767e1e2124a08c17be69bf0f847c882e"><code>b8d2f46</code></a> Backport PR <a href="https://github-redirect.dependabot.com/pandas-dev/pandas/issues/49070">#49070</a> on branch 1.5.x (CI: Fix DeprecationWarning of numpy dev) ...</li> <li>Additional commits viewable in <a href="https://github.com/pandas-dev/pandas/compare/v1.5.0...v1.5.1">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 4748: Bump scipy from 1.9.2 to 1.9.3 r=jenshnielsen a=dependabot[bot] Bumps [scipy](https://github.com/scipy/scipy) from 1.9.2 to 1.9.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/scipy/scipy/releases">scipy's releases</a>.</em></p> <blockquote> <h1>SciPy 1.9.3 Release Notes</h1> <p>SciPy <code>1.9.3</code> is a bug-fix release with no new features compared to <code>1.9.2</code>.</p> <h1>Authors</h1> <ul> <li>Jelle Aalbers (1)</li> <li>Peter Bell (1)</li> <li>Jake Bowhay (3)</li> <li>Matthew Brett (3)</li> <li>Evgeni Burovski (5)</li> <li>drpeteb (1) +</li> <li>Sebastian Ehlert (1) +</li> <li>GavinZhang (1) +</li> <li>Ralf Gommers (2)</li> <li>Matt Haberland (15)</li> <li>Lakshaya Inani (1) +</li> <li>Joseph T. Iosue (1)</li> <li>Nathan Jacobi (1) +</li> <li>jmkuebler (1) +</li> <li>Nikita Karetnikov (1) +</li> <li>Lechnio (1) +</li> <li>Nicholas McKibben (1)</li> <li>Andrew Nelson (1)</li> <li>o-alexandre-felipe (1) +</li> <li>Tirth Patel (1)</li> <li>Tyler Reddy (51)</li> <li>Martin Reinecke (1)</li> <li>Marie Roald (1) +</li> <li>Pamphile Roy (2)</li> <li>Eli Schwartz (1)</li> <li>serge-sans-paille (1)</li> <li>ehsan shirvanian (1) +</li> <li>Mamoru TASAKA (1) +</li> <li>Samuel Wallan (1)</li> <li>Warren Weckesser (7)</li> <li>Gavin Zhang (1) +</li> </ul> <p>A total of 31 people contributed to this release. People with a "+" by their names contributed a patch for the first time. This list of names is automatically generated, and may not be fully complete.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/scipy/scipy/commit/de80faf9d3480b9dbb9b888568b64499e0e70c19"><code>de80faf</code></a> REL: set 1.9.3 released [wheel build]</li> <li><a href="https://github.com/scipy/scipy/commit/25e6b901077646cbdaf0a022ff63d55b2c40b114"><code>25e6b90</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/scipy/scipy/issues/17239">#17239</a> from tylerjereddy/treddy_backport_193</li> <li><a href="https://github.com/scipy/scipy/commit/ba33e438f948d5e147755aff0e63f6a01f5bc676"><code>ba33e43</code></a> DOC: update 1.9.3 relnotes</li> <li><a href="https://github.com/scipy/scipy/commit/92d892efaf689c1be970370cd9b33678482fb1fd"><code>92d892e</code></a> MAINT: Handle numpy's deprecation of accepting out-of-bound integers.</li> <li><a href="https://github.com/scipy/scipy/commit/ba5f6daa1d855f43f9f0d19f51386285b2835ce8"><code>ba5f6da</code></a> MAINT: PR 17239 revisions</li> <li><a href="https://github.com/scipy/scipy/commit/381089e753b42c26faf3fb689fc82f7a5c34c422"><code>381089e</code></a> DOC: update 1.9.3 relnotes</li> <li><a href="https://github.com/scipy/scipy/commit/2db3440cfd768009847fb355f3da53fc8c562ea3"><code>2db3440</code></a> BLD: fix invalid shebang for build helper script</li> <li><a href="https://github.com/scipy/scipy/commit/a9a6582a38e23f178ddaed874d1bc65de3313cb2"><code>a9a6582</code></a> DOC: stats.mode: add versionadded tag and correct order of keepdims descripti...</li> <li><a href="https://github.com/scipy/scipy/commit/f4738889bd34d294cfcbd4aaed8c914fe961a0fd"><code>f473888</code></a> BLD: fix issue with incomplete threads dependency handling (<a href="https://github-redirect.dependabot.com/scipy/scipy/issues/17200">#17200</a>)</li> <li><a href="https://github.com/scipy/scipy/commit/5370f15752eef1f62773236704d6339fa4d4e99c"><code>5370f15</code></a> MAINT: update meson.build to make it work on IBM i system (<a href="https://github-redirect.dependabot.com/scipy/scipy/issues/17193">#17193</a>)</li> <li>Additional commits viewable in <a href="https://github.com/scipy/scipy/compare/v1.9.2...v1.9.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=scipy&package-manager=pip&previous-version=1.9.2&new-version=1.9.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Keysight N5245A driver

301e6fb

johnhornibrook changed the title ~~Driver for Keysight N5245A~~ driver/Keysight N5245A Oct 21, 2017

Merge branch 'master' into driver-n5245a

7551ea3

Merge remote-tracking branch 'qcodes/master' into driver-n5245a

70f6437

spauka added 13 commits June 7, 2018 10:05

Merge remote-tracking branch 'qcodes/master' into driver-n5245a

2ab48e6

Add new array parameters to PNA driver

d2ff2c9

Make PNA driver generic

4af2c89

Make driver generic, extend with traces and ports

a8136cb

Add initializer for N5245A PNA

9dcbda9

Allow channel lists to be cleared

92d0bfa

Add nports to N5245A

a0051d1

Remove multi-parameters, not compatible with new dataset

c98754b

Add FOM parameters

2cbb44b

Fix parameter getting

4e5fc69

Add mypy annotations

e8c6385

Ignore typing on overloaded properties

c73b215

Add N5230C driver as well

1da1635

Merge branch 'master' into driver-n5245a

3d76208

jenshnielsen and others added 5 commits July 23, 2018 09:56

make register_parameter match add_result for array_parameter

fb5aa72

Add docstring to clear

64dad3c

Fix codacy errors

9cea3f7

- Lots of trailing white space - rename variables - fix format string

Remove unused imports

e5144b0

Merge branch 'master' into driver-n5245a

ac8120f

jenshnielsen reviewed Jul 23, 2018

View reviewed changes

jenshnielsen approved these changes Jul 23, 2018

View reviewed changes

Fix whitespace and formatting

95e8d67

spauka added 3 commits July 26, 2018 16:08

Move run_sweep to trace

525988d

Add tests for channel clear

77a1de4

Add Keysight PNA driver example

9417600

Remove unused variable

d4db4a8

astafan8 reviewed Jul 26, 2018

View reviewed changes

spauka added 4 commits July 27, 2018 11:28

Rearrange trace parameters, change auto_sweep implementation

ae6d5c0

Clarify comment on traces

f433164

Set active trace in correct location

8f73d57

Merge branch 'master' into driver-n5245a

e9e13cf

astafan8 merged commit 3d49344 into microsoft:master Jul 27, 2018

giulioungaretti pushed a commit that referenced this pull request Jul 27, 2018

Generated gh-pages for commit 3d49344

85c9f94

Merge: f7b173f e9e13cf Author: Mikhail Astafev <[email protected]> Merge pull request #807 from johnhornibrook/driver-n5245a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

driver/Keysight N5245A #807

driver/Keysight N5245A #807

johnhornibrook commented Oct 21, 2017

WilliamHPNielsen commented Dec 6, 2017

codecov bot commented Apr 23, 2018 •

edited

Loading

johnhornibrook commented May 16, 2018

jenshnielsen commented Jul 20, 2018

spauka commented Jul 22, 2018

jenshnielsen Jul 23, 2018

spauka Jul 23, 2018 •

edited

Loading

jenshnielsen Jul 23, 2018 •

edited

Loading

jenshnielsen left a comment

jenshnielsen Jul 23, 2018

spauka Jul 23, 2018

jenshnielsen Jul 23, 2018

spauka Jul 23, 2018

jenshnielsen Jul 23, 2018

spauka Jul 23, 2018

spauka commented Jul 23, 2018

spauka commented Jul 26, 2018 •

edited

Loading

astafan8 Jul 26, 2018

spauka Jul 27, 2018

astafan8 Jul 26, 2018

spauka Jul 27, 2018 •

edited

Loading

astafan8 Jul 26, 2018

spauka Jul 27, 2018 •

edited

Loading

astafan8 Jul 27, 2018

astafan8 Jul 26, 2018

spauka Jul 27, 2018

astafan8 Jul 27, 2018

driver/Keysight N5245A #807

driver/Keysight N5245A #807

Conversation

johnhornibrook commented Oct 21, 2017

WilliamHPNielsen commented Dec 6, 2017

codecov bot commented Apr 23, 2018 • edited Loading

Codecov Report

johnhornibrook commented May 16, 2018

jenshnielsen commented Jul 20, 2018

spauka commented Jul 22, 2018

Choose a reason for hiding this comment

spauka Jul 23, 2018 • edited Loading

Choose a reason for hiding this comment

jenshnielsen Jul 23, 2018 • edited Loading

Choose a reason for hiding this comment

jenshnielsen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spauka commented Jul 23, 2018

spauka commented Jul 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spauka Jul 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spauka Jul 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 23, 2018 •

edited

Loading

spauka Jul 23, 2018 •

edited

Loading

jenshnielsen Jul 23, 2018 •

edited

Loading

spauka commented Jul 26, 2018 •

edited

Loading

spauka Jul 27, 2018 •

edited

Loading

spauka Jul 27, 2018 •

edited

Loading