[FancyZones] Set 3-zones PriorityGrid as default layout #6248
Conversation
| } | ||
| else | ||
| { | ||
| deviceInfoMap[deviceId] = DeviceInfoData{ ZoneSetData{ NonLocalizable::NullStr, ZoneSetLayoutType::Blank } }; |
There was a problem hiding this comment.
Should we add anything into deviceInfoMap in this case? I remember that ZoneSetLayoutType::Blank has been added for some purpose, but I can't recall why exactly.
Everywhere there are checks if zone set UUID is valid and ZoneSetLayoutType is not Blank. It won't be saved in the settings file and just takes a place in the memory.
There was a problem hiding this comment.
I'll double check whether Blank type and checks are still needed at all
There was a problem hiding this comment.
Keep in mind that we will add functionality to the editor to set no zoneset on a desktop.
There was a problem hiding this comment.
🔼 That's why it is still needed :)
stefansjfw
force-pushed
the
stefan/default_layout_impl
branch
from
ec82119
to
21be412
Compare
stefansjfw
force-pushed
the
stefan/default_layout_impl
branch
from
21be412
to
58dc856
Compare
| wil::unique_cotaskmem_string guidString; | ||
| if (result == S_OK && SUCCEEDED(StringFromCLSID(guid, &guidString))) | ||
| { | ||
| DeviceInfoData defaultDeviceInfoData{ ZoneSetData{ guidString.get(), ZoneSetLayoutType::PriorityGrid }, true, 16, 3 }; |
There was a problem hiding this comment.
Can you replace true, 16 and 3 with consts or explicit argument names?
|
Code looks good, tested and works as expected. |
Summary of the Pull Request
What is this about?
Instead of no-layout at FZ startup, now 3-zones PriorityGrid is applied by default.
PR Checklist
Validation Steps Performed
How does someone test & validate?