-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/ryanbod/shell plugin fxcop #6043
Merged
ryanbodrug-microsoft
merged 9 commits into
microsoft:master
from
ryanbodrug-microsoft:user/ryanbod/shell_plugin_fxcop
Aug 21, 2020
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e9656e3
Enabling FxCop static analysis.
ryanbodrug-microsoft e163734
Fixes for CA2227 Change 'Count' to be read-only by removing the prope…
ryanbodrug-microsoft c744fae
Fix for: CA1822: Mark members as static
ryanbodrug-microsoft 99973b6
Fix for CA1805: Do not initialize unnecessarily.
ryanbodrug-microsoft 49c1b46
Fix for: Error CA1724 The type name Settings conflicts in whole or in…
ryanbodrug-microsoft bb91821
Severity Code Description Project File Line Suppression State
ryanbodrug-microsoft dcef562
Fix for CA1307: Specify StringComparison & CA1305: Specify IFormatPro…
ryanbodrug-microsoft 5580913
Fix for CA1062: Validate arguments of public methods
ryanbodrug-microsoft 519eedc
Suppressing CA1031 Modify 'Query' to catch a more specific allowed ex…
ryanbodrug-microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the false initialisation removed because we are planning to override Win+R?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alekhyareddy28 . Nope this was to fix CA1805. It is redundant to initialize a field to its default value.
Rule description
The .NET runtime initializes all fields of reference types to their default values before running the constructor. In most cases, explicitly initializing a field to its default value in a constructor is redundant, adding maintenance costs and potentially degrading performance (such as with increased assembly size), and the explicit initialization can be removed.