Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User/ryanbod/shell plugin fxcop #6043

Merged
merged 9 commits into from
Aug 21, 2020
Merged

User/ryanbod/shell plugin fxcop #6043

merged 9 commits into from
Aug 21, 2020

Commits on Aug 19, 2020

  1. Enabling FxCop static analysis.

    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e9656e3 View commit details
    Browse the repository at this point in the history

  2. Fixes for CA2227 Change 'Count' to be read-only by removing the prope… 

    …rty setter.

https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2227?view=vs-2019
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e163734 View commit details
    Browse the repository at this point in the history

  3. Fix for: CA1822: Mark members as static 

    https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822?view=vs-2019
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c744fae View commit details
    Browse the repository at this point in the history

  4. Fix for CA1805: Do not initialize unnecessarily. 

    https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1805?view=vs-2019
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    99973b6 View commit details
    Browse the repository at this point in the history

  5. Fix for: Error CA1724 The type name Settings conflicts in whole or in… 

    … part with the namespace name 'Microsoft.PowerToys.Settings'. Change either name to eliminate the conflict. Microsoft.Plugin.Shell C:\repos\powertoys\src\modules\launcher\Plugins\Microsoft.Plugin.Shell\Settings.cs 9 Active
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    49c1b46 View commit details
    Browse the repository at this point in the history

  6. Severity Code Description Project File Line Suppression State 

    Error CA1724 The type name Settings conflicts in whole or in part with the namespace name 'Microsoft.PowerToys.Settings'. Change either name to eliminate the conflict. Microsoft.Plugin.Shell C:\repos\powertoys\src\modules\launcher\Plugins\Microsoft.Plugin.Shell\Settings.cs 9 Active
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    bb91821 View commit details
    Browse the repository at this point in the history

  7. Fix for CA1307: Specify StringComparison & CA1305: Specify IFormatPro… 

    …vider

https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1307?view=vs-2019
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305?view=vs-2019
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    dcef562 View commit details
    Browse the repository at this point in the history

  8. Fix for CA1062: Validate arguments of public methods 

    https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1062?view=vs-2019
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5580913 View commit details
    Browse the repository at this point in the history

  9. Suppressing CA1031 Modify 'Query' to catch a more specific allowed ex… 

    …ception type, or rethrow the exception'
    @ryanbodrug-microsoft
    ryanbodrug-microsoft committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    519eedc View commit details
    Browse the repository at this point in the history