Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert CommunityToolkit update to fix ARM settings app crash #35139

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

stefansjfw
Copy link
Collaborator

@stefansjfw stefansjfw commented Sep 30, 2024

Summary of the Pull Request

Partially revert #34419 as new version of Community toolkit packages causes settings app crash on startup on ARM with following exception:

[21:32:45.9264781] [Error] App::App_UnhandledException
    Unhandled exception
Array dimensions exceeded supported range.
Inner exception: 

Stack trace: 
   at CommunityToolkit.WinUI.Controls.StaggeredLayout.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at Microsoft.UI.Xaml.Controls.VirtualizingLayout.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.MeasureOverride(VirtualizingLayoutContext context, Size availableSize)
   at ABI.Microsoft.UI.Xaml.Controls.IVirtualizingLayoutOverrides.Do_Abi_MeasureOverride_2(IntPtr thisPtr, IntPtr context, Size availableSize, Size* result)

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All touched utilities sanity checked and seem to work well:

  • Advanced Paste
  • Environment Variables
  • File Locksmith
  • Hosts
  • Peek
  • RegistryPreview
  • Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants