Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable) #34419

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Aug 24, 2024

Summary of the Pull Request

Upgrade of the WinUI Toolkit. This will upgrade the target .net framework as well as a requirement for Toolkit

Reviewer notes:

  1. Things to note that i found odd, WorkspacesLib.vcxproj required me to add in CppWinRT for some reason.

Moving parts:

This is one of 4 major upgrades we need to accomplish for AoT for WinUI.

  1. CsWinRT 2.1.1<- Draft PR Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable) #34419
  2. WinAppSDK 1.6<- Draft PR Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable) #34419
  3. Toolkit <- this PR

Bonus points:

  1. Vcxproj prop abstraction for WinAppSdk
  2. CppWinRT

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@crutkas crutkas changed the title Community Toolkit upgrade ... take 2 [DRAFT] Community Toolkit upgrade to 8.1.240821 Aug 26, 2024
@crutkas
Copy link
Member Author

crutkas commented Aug 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

NOTICE.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
@crutkas crutkas marked this pull request as ready for review August 27, 2024 03:40
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 27, 2024
@crutkas crutkas changed the title [DRAFT] Community Toolkit upgrade to 8.1.240821 Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable) Aug 27, 2024
@crutkas
Copy link
Member Author

crutkas commented Aug 28, 2024

testing against dart

@crutkas
Copy link
Member Author

crutkas commented Sep 11, 2024

crap, looks like the merge broke stuff

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a all around test from the Dart binaries. LGTM! Code changes look good as well. Thank you!

@crutkas crutkas merged commit 5b0f3f6 into main Sep 12, 2024
15 checks passed
@crutkas crutkas deleted the dev/crutkas/upgradeToolkitTake2 branch September 12, 2024 16:30
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.85 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants