-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable) #34419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crutkas
changed the title
Community Toolkit upgrade ... take 2
[DRAFT] Community Toolkit upgrade to 8.1.240821
Aug 26, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
crutkas
added
the
Needs-Review
This Pull Request awaits the review of a maintainer.
label
Aug 27, 2024
crutkas
changed the title
[DRAFT] Community Toolkit upgrade to 8.1.240821
Community Toolkit upgrade to 8.1.240821 (after .84 is verified stable)
Aug 27, 2024
testing against dart |
11 tasks
crap, looks like the merge broke stuff |
jaimecbernardo
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a all around test from the Dart binaries. LGTM! Code changes look good as well. Thank you!
ethanfangg
approved these changes
Sep 12, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Upgrade of the WinUI Toolkit. This will upgrade the target .net framework as well as a requirement for Toolkit
Reviewer notes:
Moving parts:
This is one of 4 major upgrades we need to accomplish for AoT for WinUI.
Bonus points:
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed