[HotFix][RegistryPreview]Fix out of bonds array access error #28803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecbernardo
added
the
Hot Fix
stefansjfw
approved these changes
Sep 27, 2023
|
I actually didn't catch this until after the PR was merged. Seems to be an intermittent bug (at least for me), because it worked fine when opening the file but when trying to edit it crashed. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
After #28488, Registry preview does some escape character checks. On this code there's an iterator increment that doesn't recheck for bounds, so this was causing a out of bonds exception for some files, like the one presented in the issue.
PR Checklist
Validation Steps Performed
Opened the file indicated as crashing in the issue and verified it no longer crashes Registry Preview.