-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Registry Preview] Better preview in data grid like in Regedit #28488
[Registry Preview] Better preview in data grid like in Regedit #28488
Conversation
Hah: when I saw the screenshots, I thought the goal was to replace the WinUI 3 grid with a LIstView, which made me very conflicted. In terms of testing this, please revisit all the resolved bugs on the program: there are lots of little things reported by people that wanted the app to be a "creator" rather than an "editor" which uncovered to issues with odd things. Like trailing comments on data lines or data that crosses over two lines but with added white space. Made the "parsing" routine a tad larger and convoluted, sort of like using bubble gum to plug holes. I also assume that multiple languages were included in the testing, in addition to the emoji? When asked "why aren't you showing text for SZ_MULTI" I replied with NYI and ran away from the question! :) |
src/modules/registrypreview/RegistryPreviewUI/Strings/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Would it make sense to support Reg_Multi_Sz multi-line preview in a read-only content Dialog? |
Hi @randyrants , do you feel the recent changes addressed your feedback? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M! We'll know more as people start to run their files through it - that's where I found the majority of bugs with stuff like this.
@htcfreek What about showing it in a flyout or tooltip? |
@dillydylann (Should I open a new issues?) |
Summary of the Pull Request
This PR updates the data grid in Registry Preview to properly show the data values shown in Registry Editor.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Left: Registry Preview | Right: Registry Editor