[FindMyMouse]Fix hang on top left activation #19347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix the issue where Find My Mouse is hanging when activated on the top left corner of the screen.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The initial code uses the (-1,-1) coordinates to identify if mouse movement has been detected since activating FindMyMouse from the async RawInput handler. Windows 11 reports (-1,-1) as the top left corner of a single monitor setup so this makes little sense for that case. This PR uses (LONG_MIN, LONG_MIN) as the null point instead.
Validation Steps Performed
Verified that 0.60 replicated the issue on a machine and this fix works well on that same machine.