Adding new filetypes for developer file preview #17183

Aaron-Junker · 2022-03-21T17:08:01Z

Summary of the Pull Request

What is this about:

What is included in the PR:

Preview for reg files (self written!)
New extensions for XML preview: ".xslt", ".xsd", ".wsdl"
New extensions for c++ preview: ".ino", ".pde"
New extension for cshtml preview: ".razor"

A system to add costum file types. Only downside is that you have to copy paste the language definitions into monacoSpecialLanguages.js

How does someone test / validate:

Install and test with new file types

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Aaron-Junker · 2022-03-21T17:09:39Z

@stefansjfw Could you please make the installer stuff:

Including "costumLanguages" folder
Including "monacoSpecialLanguages.js"

This would be very nice.

stefansjfw · 2022-03-22T12:16:49Z

@stefansjfw Could you please make the installer stuff:

Including "costumLanguages" folder

Including "monacoSpecialLanguages.js"

This would be very nice.

Sure. Could you please rebase this work on top of latest main?

htcfreek · 2022-03-22T16:54:54Z

@Aaron-Junker
Are the words marked by spell checker predefined or can we change casing here to lowerCamelCase?

…aco-new-languages

Aaron-Junker · 2022-03-23T15:41:28Z

@stefansjfw I main master in

src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandler.csproj

src/modules/previewpane/MonacoPreviewHandler/generateLanguagesJson.html

src/settings-ui/Settings.UI/Settings.UI.csproj

src/modules/previewpane/MonacoPreviewHandler/monaco_languages.json

htcfreek · 2022-03-29T11:30:23Z

Regarding reg format:
Can you define special colored elements? Then we could color keys/values to delete in red. (I suggest to color the whole line in red like np++ does for deleted keys.

Delete key

[-hklm\key-to-delete]

Delete value

"value-to-delete"=-

And let's have the constants in purple to look different in all color modes.

Btw. there is a test wep page you can use to validate your colors.

Aaron-Junker · 2022-03-29T13:29:39Z

Regarding reg format:
Can you define special colored elements? Then we could color keys/values to delete in red. (I suggest to color the whole line in red like np++ does for deleted keys.

Delete key
[-hklm\key-to-delete]
Delete value
"value-to-delete"=-

Tjis should be possible. Thanks for the suggestion.

And let's have the constants in purple to look different in all color modes.

Btw. there is a test wep page you can use to validate your colors.

I can't define the color just the type of a element.

GitMensch · 2022-04-04T21:47:12Z

A note in doc/devdocs/modules/powerpreview/monaco/readme.md about how to add languages which don't have a reasonable mapping for in monaco would be good (likely "add to monaco first", but I haven't found information on that either).

Aaron-Junker · 2022-04-05T06:03:09Z

A note in doc/devdocs/modules/powerpreview/monaco/readme.md about how to add languages which don't have a reasonable mapping for in monaco would be good (likely "add to monaco first", but I haven't found information on that either).

I agree. Will look what I can provide. What did you want to integrate?

GitMensch · 2022-04-05T06:14:05Z

What did you want to integrate?

Whatever I stumble over :-)
Form my current source tree:

COBOL (.cob/.cbl) would likely be "totally new";
autoconf (.ac, .at; which may be aliased to .m4 if that exists, but that isn't highlighted so far)

Side note: if ".in" isn't aliased to .txt altrit should be added, too, similar for .rc (I may have a manual provider as text setup, would need to check); automake (.am) should be aliased to Makefile; .sln + .vcxproj may be aliased to xml if there's no better match;

Aaron-Junker · 2022-04-10T15:21:49Z

Will this also handle .xslt? We use .xsl for html pages using xsl and .xslt for other transformation. Thanks for adding these!

I will add these too,

GitMensch · 2022-04-10T15:23:15Z

Looks like I've asked in the wrong post, please add ".log", ".err", ".out" as text to fix #17506.

Aaron-Junker · 2022-04-10T15:48:14Z

@htcfreek I added your suggestions.

@stefansjfw This is now ready for review

Aaron-Junker · 2022-04-10T15:49:30Z

I will add the docs later

htcfreek · 2022-04-10T18:30:19Z

@Aaron-Junker
What do you think about this:

return {
        tokenPostfix: '.reg',
        tokenizer: {
            root: [
                // Header (case sensitive)
                [/Windows Registry Editor Version 5.00/, 'comment'],
                [/REGEDIT4/, 'comment'],
                // Comments
                [/;.*/, "comment"],
                // Keys
                [/\[\-.*\]/, 'invalid'],
                [/\\.*[^\]]/, 'keyword'],
                // Values
                [/@/, "keyword"],
                [/\".*\"=\-/, "invalid"],
                [/\".*\"(?=\=)/, "keyword"],
                [/\".*\"(?!\=)/, 'string'],
                [/((hex\({0,1}[0-9,a,b]*\){0,1})|dword):.*/, "string"],
                // Hive names (case in-sensitive)
                [/HKEY_CLASSES_ROOT/, 'type'],
                [/HKEY_LOCAL_MACHINE/, 'type'],
                [/HKEY_USERS/, 'type'],
                [/HKEY_CURRENT_USER/, 'type'],
                [/HKEY_PERFORMANCE_DATA/, 'type'],
                [/HKEY_DYN_DATA/, 'type'],
                [/hkey_classes_root/, 'type'],
                [/hkey_local_machine/, 'type'],
                [/hkey_users/, 'type'],
                [/hkey_current_user/, 'type'],
                [/hkey_performance_data/, 'type'],
                [/hkey_dyn_data/, 'type'],
                // Symbols (For better contrast on hc-black)
                [/=/, 'delimiter'],
                [/\[/, 'delimiter'],
                [/]/, 'delimiter'],
            ]
        }
    }

htcfreek · 2022-04-10T19:09:58Z

Or with special color for value type:

return {
        tokenPostfix: '.reg',
        tokenizer: {
            root: [
                // Header (case sensitive)
                [/Windows Registry Editor Version 5.00/, 'comment'],
                [/REGEDIT4/, 'comment'],
                // Comments
                [/;.*/, "comment"],
                // Keys
                [/\[\-.*\]/, 'invalid'],
                [/\\.*[^\]]/, 'keyword'],
                // Values
                [/@/, "keyword"],
                [/\".*\"=\-/, "invalid"],
                [/\".*\"(?=\=)/, "keyword"],
                [/\".*\"(?!\=)/, 'string'],
                [/hex\({0,1}[0-9,a,b]\)|hex|dword(?=\:)/, "type"],
                [/[0-9,a-f,A-F][0-9,a-f,A-F],*/, 'string'],
                // Hive names (case in-sensitive)
                [/HKEY_CLASSES_ROOT/, 'type'],
                [/HKEY_LOCAL_MACHINE/, 'type'],
                [/HKEY_USERS/, 'type'],
                [/HKEY_CURRENT_USER/, 'type'],
                [/HKEY_PERFORMANCE_DATA/, 'type'],
                [/HKEY_DYN_DATA/, 'type'],
                [/hkey_classes_root/, 'type'],
                [/hkey_local_machine/, 'type'],
                [/hkey_users/, 'type'],
                [/hkey_current_user/, 'type'],
                [/hkey_performance_data/, 'type'],
                [/hkey_dyn_data/, 'type'],
                // Symbols (For better contrast on hc-black)
                [/=/, 'delimiter'],
                [/\[/, 'delimiter'],
                [/]/, 'delimiter'],
                [/:/, 'delimiter'],
            ]
        }
    }

src/modules/previewpane/MonacoPreviewHandler/monaco_languages.json

Aaron-Junker · 2022-04-11T05:29:03Z

Or with special color for value type:

return {
        tokenPostfix: '.reg',
        tokenizer: {
            root: [
                // Header (case sensitive)
                [/Windows Registry Editor Version 5.00/, 'comment'],
                [/REGEDIT4/, 'comment'],
                // Comments
                [/;.*/, "comment"],
                // Keys
                [/\[\-.*\]/, 'invalid'],
                [/\\.*[^\]]/, 'keyword'],
                // Values
                [/@/, "keyword"],
                [/\".*\"=\-/, "invalid"],
                [/\".*\"(?=\=)/, "keyword"],
                [/\".*\"(?!\=)/, 'string'],
                [/hex\({0,1}[0-9,a,b]\)|hex|dword(?=\:)/, "type"],
                [/[0-9,a-f,A-F][0-9,a-f,A-F],*/, 'string'],
                // Hive names (case in-sensitive)
                [/HKEY_CLASSES_ROOT/, 'type'],
                [/HKEY_LOCAL_MACHINE/, 'type'],
                [/HKEY_USERS/, 'type'],
                [/HKEY_CURRENT_USER/, 'type'],
                [/HKEY_PERFORMANCE_DATA/, 'type'],
                [/HKEY_DYN_DATA/, 'type'],
                [/hkey_classes_root/, 'type'],
                [/hkey_local_machine/, 'type'],
                [/hkey_users/, 'type'],
                [/hkey_current_user/, 'type'],
                [/hkey_performance_data/, 'type'],
                [/hkey_dyn_data/, 'type'],
                // Symbols (For better contrast on hc-black)
                [/=/, 'delimiter'],
                [/\[/, 'delimiter'],
                [/]/, 'delimiter'],
                [/:/, 'delimiter'],
            ]
        }
    }

I love it. Thank you so much.

src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandler.csproj

src/modules/previewpane/MonacoPreviewHandler/monacoSpecialLanguages.js

stefansjfw

How did you test this?

I tried building installer and installing PT and monaco doesn't work even for old file types..

src/modules/previewpane/MonacoPreviewHandler/monacoSpecialLanguages.js

src/modules/previewpane/MonacoPreviewHandler/index.html

Aaron-Junker · 2022-04-11T11:26:03Z

How did you test this?

I tried building installer and installing PT and monaco doesn't work even for old file types..

I added the files and registry keys manually. I will look why this happens.

stefansjfw · 2022-04-11T11:41:41Z

How did you test this?
I tried building installer and installing PT and monaco doesn't work even for old file types..

I added the files and registry keys manually. I will look why this happens.

Sorry, my bad. You already asked for installer stuff and I somehow though I already did that. Here it is..

stefansjfw · 2022-04-11T11:43:35Z

@Aaron-Junker Can you try the installer now and all new extensions? For me e.g. xslt doesn't seem to work, but wsdl works for some reason..

Aaron-Junker · 2022-04-11T11:46:08Z

@Aaron-Junker Can you try the installer now and all new extensions? For me e.g. xslt doesn't seem to work, but wsdl works for some reason..

I forgot to generate a new monaco_languages.json file after adding xslt.

Aaron-Junker · 2022-04-11T11:46:43Z

How did you test this?
I tried building installer and installing PT and monaco doesn't work even for old file types..

I added the files and registry keys manually. I will look why this happens.

Sorry, my bad. You already asked for installer stuff and I somehow though I already did that. Here it is..

Thanks.

htcfreek · 2022-04-11T15:14:48Z

@Aaron-Junker
let's add this page to our docs: https://microsoft.github.io/monaco-editor/monarch.html

Aaron-Junker · 2022-04-11T15:30:31Z

@htcfreek As I stated above

I will add the docs later

Co-authored-by: htcfreek <[email protected]>

…ub.com/microsoft/PowerToys into user/aaron-junker/monaco-new-languages

stefansjfw · 2022-04-12T20:47:17Z

@Aaron-Junker Can you try the installer now and all new extensions? For me e.g. xslt doesn't seem to work, but wsdl works for some reason..

I forgot to generate a new monaco_languages.json file after adding xslt.

this is still TBD, right ?

Aaron-Junker · 2022-04-13T15:31:22Z

@Aaron-Junker Can you try the installer now and all new extensions? For me e.g. xslt doesn't seem to work, but wsdl works for some reason..

I forgot to generate a new monaco_languages.json file after adding xslt.

this is still TBD, right ?

Forgot about it. Should be ready now.

stefansjfw

looks good. nice work

htcfreek · 2022-05-04T16:32:42Z

isn't this shipped with 0.58.0?

Aaron-Junker · 2022-05-04T16:57:54Z

isn't this shipped with 0.58.0?

Yes why?

htcfreek · 2022-05-04T19:58:23Z

isn't this shipped with 0.58.0?

Yes why?

Didn't work for me. .reg is not shown with dev preview. It's shown as plain text with I think default provider.

Aaron-Junker · 2022-05-04T20:36:31Z

isn't this shipped with 0.58.0?

Yes why?

Didn't work for me. .reg is not shown with dev preview. It's shown as plain text with I think default provider.

Open a new issue. I will look this this weekend what is going on.

Aaron-Junker added 3 commits March 21, 2022 18:00

push

ae147dd

push

bb376f0

push

f3e74f8

Merge remote-tracking branch 'origin/main' into user/aaron-junker/mon…

1c1c1ba

…aco-new-languages

stefansjfw reviewed Mar 23, 2022

View reviewed changes

Adressed comments and adjusted a thing

f71b00b

Aaron-Junker added 4 commits April 10, 2022 17:23

Added xslt

fd67d54

push

93719cc

Merge branch 'main' into user/aaron-junker/monaco-new-languages

9d80808

push. Ready to review

b9e28fe

Aaron-Junker marked this pull request as ready for review April 10, 2022 15:47

Aaron-Junker requested a review from stefansjfw April 10, 2022 15:48

Spellcheck adjustments

d3786ef

microsoft deleted a comment from github-actions bot Apr 10, 2022

htcfreek reviewed Apr 10, 2022

View reviewed changes

src/modules/previewpane/MonacoPreviewHandler/monaco_languages.json Show resolved Hide resolved

stefansjfw reviewed Apr 11, 2022

View reviewed changes

src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandler.csproj Outdated Show resolved Hide resolved

stefansjfw reviewed Apr 11, 2022

View reviewed changes

src/modules/previewpane/MonacoPreviewHandler/monacoSpecialLanguages.js Outdated Show resolved Hide resolved

stefansjfw reviewed Apr 11, 2022

View reviewed changes

src/modules/previewpane/MonacoPreviewHandler/monacoSpecialLanguages.js Show resolved Hide resolved

src/modules/previewpane/MonacoPreviewHandler/index.html Show resolved Hide resolved

Add installer stuff

43f190e

Aaron-Junker changed the title ~~[WIP] Adding new filetypes for developer file preview~~ Adding new filetypes for developer file preview Apr 11, 2022

Aaron-Junker and others added 3 commits April 12, 2022 17:56

Changed reg and removed xsl

75359b4

Co-authored-by: htcfreek <[email protected]>

Merge branch 'user/aaron-junker/monaco-new-languages' of https://gith…

1bface0

…ub.com/microsoft/PowerToys into user/aaron-junker/monaco-new-languages

Fixed tab

440b3da

Aaron-Junker requested a review from stefansjfw April 12, 2022 16:04

Updated monaco_languages.json

2cd3d6f

stefansjfw approved these changes Apr 14, 2022

View reviewed changes

jaimecbernardo merged commit d9c8d8d into main Apr 14, 2022

Aaron-Junker deleted the user/aaron-junker/monaco-new-languages branch April 14, 2022 14:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding new filetypes for developer file preview #17183

Adding new filetypes for developer file preview #17183

Aaron-Junker commented Mar 21, 2022 •

edited

Loading

Aaron-Junker commented Mar 21, 2022

stefansjfw commented Mar 22, 2022

htcfreek commented Mar 22, 2022

Aaron-Junker commented Mar 23, 2022 •

edited

Loading

htcfreek commented Mar 29, 2022 •

edited

Loading

Aaron-Junker commented Mar 29, 2022

GitMensch commented Apr 4, 2022

Aaron-Junker commented Apr 5, 2022

GitMensch commented Apr 5, 2022

Aaron-Junker commented Apr 10, 2022

GitMensch commented Apr 10, 2022

Aaron-Junker commented Apr 10, 2022

Aaron-Junker commented Apr 10, 2022

htcfreek commented Apr 10, 2022 •

edited

Loading

htcfreek commented Apr 10, 2022

Aaron-Junker commented Apr 11, 2022

stefansjfw left a comment

Aaron-Junker commented Apr 11, 2022

stefansjfw commented Apr 11, 2022

stefansjfw commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

htcfreek commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

stefansjfw commented Apr 12, 2022

Aaron-Junker commented Apr 13, 2022

stefansjfw left a comment

htcfreek commented May 4, 2022

Aaron-Junker commented May 4, 2022

htcfreek commented May 4, 2022

Aaron-Junker commented May 4, 2022

Adding new filetypes for developer file preview #17183

Adding new filetypes for developer file preview #17183

Conversation

Aaron-Junker commented Mar 21, 2022 • edited Loading

Summary of the Pull Request

Quality Checklist

Contributor License Agreement (CLA)

Aaron-Junker commented Mar 21, 2022

stefansjfw commented Mar 22, 2022

htcfreek commented Mar 22, 2022

Aaron-Junker commented Mar 23, 2022 • edited Loading

htcfreek commented Mar 29, 2022 • edited Loading

Aaron-Junker commented Mar 29, 2022

GitMensch commented Apr 4, 2022

Aaron-Junker commented Apr 5, 2022

GitMensch commented Apr 5, 2022

Aaron-Junker commented Apr 10, 2022

GitMensch commented Apr 10, 2022

Aaron-Junker commented Apr 10, 2022

Aaron-Junker commented Apr 10, 2022

htcfreek commented Apr 10, 2022 • edited Loading

htcfreek commented Apr 10, 2022

Aaron-Junker commented Apr 11, 2022

stefansjfw left a comment

Choose a reason for hiding this comment

Aaron-Junker commented Apr 11, 2022

stefansjfw commented Apr 11, 2022

stefansjfw commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

htcfreek commented Apr 11, 2022

Aaron-Junker commented Apr 11, 2022

stefansjfw commented Apr 12, 2022

Aaron-Junker commented Apr 13, 2022

stefansjfw left a comment

Choose a reason for hiding this comment

htcfreek commented May 4, 2022

Aaron-Junker commented May 4, 2022

htcfreek commented May 4, 2022

Aaron-Junker commented May 4, 2022

Aaron-Junker commented Mar 21, 2022 •

edited

Loading

Aaron-Junker commented Mar 23, 2022 •

edited

Loading

htcfreek commented Mar 29, 2022 •

edited

Loading

htcfreek commented Apr 10, 2022 •

edited

Loading