Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tracker] Suggestions for file formats for developer previewer #14957

Closed
3 of 7 tasks
Aaron-Junker opened this issue Dec 11, 2021 · 19 comments
Closed
3 of 7 tasks

[Tracker] Suggestions for file formats for developer previewer #14957

Aaron-Junker opened this issue Dec 11, 2021 · 19 comments
Assignees
@Aaron-Junker
Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Tracker Issue that is used to collect multiple sub-issues about a feature

Comments

@Aaron-Junker
Copy link
Collaborator

Aaron-Junker commented Dec 11, 2021 •
edited
Loading

A list of suggested file types and from Monaco supported filetypes, where I wasn't able to find out which file extensions they use.

  • Ahk files
  • Au3
  • Reg files
  • Inf
  • vbs

XML like filetypes:

https://en.wikipedia.org/wiki/Category:XML_markup_languages

  • XSD
  • WSDL
@Aaron-Junker Aaron-Junker added Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Tracker Issue that is used to collect multiple sub-issues about a feature labels Dec 11, 2021
Aaron-Junker added a commit that referenced this issue Dec 11, 2021
@Aaron-Junker
Removed some to-do points in FileHandler.cs and added them to #14957
7c535e7
Aaron-Junker added a commit that referenced this issue Dec 11, 2021
@Aaron-Junker
Removed some to-do points in FileHandler.cs and added them to #14957.
94334b3 
Supressed a warning and styled a function better in PrebiewHandlerCommon
@niels9001 niels9001 changed the title [Tracker] Suggestions for file formats for debveloper previewer. [Tracker] Suggestions for file formats for developer previewer Dec 11, 2021
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 12, 2021
@crutkas

This comment has been minimized.

Sign in to view
@crutkas

This comment has been minimized.

Sign in to view
@crutkas

This comment has been minimized.

Sign in to view
@crutkas

This comment has been minimized.

Sign in to view
@Aaron-Junker Aaron-Junker mentioned this issue Dec 25, 2021
Merged
28 tasks
Aaron-Junker added a commit that referenced this issue Jan 25, 2022
@Aaron-Junker @crutkas
@jsoref @stefansjfw @franky920920 @htcfreek
Preview Handler for developer files (#15138)
39b98da 
* Create Readme.md

* Update Readme.md

* Rebased to master

* started integrating

* Resolve merge conflict

* Fixed merge conflict

* Edited expect.txt

* Tried implementig interfaces

* Push

* Push

* push

* push

* Deleted no longer used files

* push

* push

* Thanks @jaimecbernando for helping

* can load via url

* getting stuff semi stubbed out

* full render without passing vars

* making sure we clearly label the file was us

* push

* push

* push (does not work)

* Push

* push

* Added file size limit of 3 Kilobyte in standalone App (MoncaoPreview)

* Added monacosrc to excludes.txt (spell checker)

* Fixed XAMLHost loading issue and changed namespace of Settings.cs

* push

* Restructred some code in MonacoPreviewHandler  (not functional)

* MonacoPreview changes:

Added maximal file size and error message as values in Settings.cs
Increased maxFileSize to 10 KB
Renamed variables and formed code according to style guidelines
Added many comments
Deleted usused code
Added unimplemented(?) NavigationStarted method to prevent navigation in WebView
Fixed scrollbar issues (Not beautiful, but still better)
Removed never seen laoding window
Added some debug information as well as some Exceptions.

MonacoPreviewHandler Changes:

Changed order of code executions (still not usable)

* Push

* Push

* Push

* push

* Oh my god, it works

* Added loading screen and resize

* Added some comments, changed variable names and integrated some stuff from MonacoPreview to MonacoPreviewHandler;

* Monaco Preview Handler:
* Removed accessibilityhelpurl
* Made background of loading screen like theme selected
* dev tools open now in Debug mode automatically
* Fixed error message for too big file size

* push

* Fixed a tiny bug

* Updated a NuGet Pasckage

* Removed some to-do points in FileHandler.cs and added them to #14957

* Removed some to-do points in FileHandler.cs and added them to #14957.

Supressed a warning and styled a function better in PrebiewHandlerCommon

* Fixed 2 comment typos and a font that didn't load. (Sadly his required enable CORS again :( )

* Removed old standalone project

* Removed old unused files & rebase to master #1

* Deleted everything from the monaco source code expect the minified version

* Push

* Added summary of all functions. Restructred/simplified/clarified some code.

* Added resources

* Update bug_report.yml

* Update translation_issue.yml

* Update expect.txt

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/index.html

Co-authored-by: Josh Soref <[email protected]>

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Josh Soref <[email protected]>

* Update ProofOfConcept/MonacoPreview/monacoPreviewHandler/Resources.resx

Co-authored-by: Josh Soref <[email protected]>

* Added some additional file types

* Added additional file types

* Moved to a json file for the available languages and some other changes

* Added error message when WebView2 is not installed

* Remoing throw error

* Update expect.txt

* Update excludes.txt

* Update excludes.txt

* Integrate Monaco preview handler into PowerToys

* Update excludes.txt

* Ignore .svg extension

* Update signing list

* Update signing list #2

* Changed monaco string

* fix

* Fixed wrong JSON field and changed date of Copyright

* Added check if WebView is installed

* Added error when webview2 is not installed

* Increased file size limit to 50kb

* Added new file generator for languages.json

* Remove unvisible symbol at the beggining of the file

* Regenerate resx file

* Update MonacoPreviewHandler.csproj

* tweaking script to ignore 1.0 check on theme dll

* Update src/modules/previewpane/MonacoPreviewHandler/Properties/Resources.resx

Co-authored-by: Franky Chen <[email protected]>

* Update src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Franky Chen <[email protected]>

* Update src/modules/previewpane/MonacoPreviewHandler/MonacoPreviewHandlerControl.cs

Co-authored-by: Franky Chen <[email protected]>

* Update src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

Co-authored-by: Franky Chen <[email protected]>

* Update excludes.txt

* Update src/modules/previewpane/powerpreview/Resources.resx

Co-authored-by: Franky Chen <[email protected]>

* Check and install WebView2 if needed

* Run spellcheck script

* Update ESRPSigning_core.json

adding font

* Update versionAndSignCheck.ps1

adding fonts to verify

* Adding in Monaco usage

* Update NOTICE.md

* Update ESRPSigning_core.json

* expect.txt update

* Use Common.UI/ThemeManager.cs

* No user facing strings should reference Monaco

* Fix build error

* monaco devdocs (#15691)

* Create update-monaco-editor.md

* Update and rename update-monaco-editor.md to readme.md

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update doc/devdocs/modules/powerpreview/monaco/readme.md

Co-authored-by: Heiko <[email protected]>

* Update readme.md

* Update readme.md

Co-authored-by: Heiko <[email protected]>

* Fix WebView installer condition

* Using system.text.json

* Update ESRPSigning_core.json

* Remove Newtonsoft.Json.dll from installer

* Revert "WinUI bump (#15707)"

This reverts commit b6a207c.

* Revert "Update Settings.UI.csproj (#15704)"

This reverts commit 1a25dac.

Co-authored-by: Clint Rutkas <[email protected]>
Co-authored-by: Aaron Junker <[email protected]>
Co-authored-by: Clint Rutkas <[email protected]>
Co-authored-by: Josh Soref <[email protected]>
Co-authored-by: Stefan Markovic <[email protected]>
Co-authored-by: Franky Chen <[email protected]>
Co-authored-by: Heiko <[email protected]>
@htcfreek
Copy link
Collaborator

htcfreek commented Jan 26, 2022 •
edited
Loading

I would like to have:

  • .ahk (AutoHotkey)
  • .au3 (AutoIT v3)
  • .inf (?)
  • .reg (Registry export)

But both aren't supported by Monaco.

@Aaron-Junker
Copy link
Collaborator Author

I would like to have:

  • .ahk (AutoHotkey)
  • .au3 (AutoIT v3)
  • .inf (?)
  • .reg (Registry export)

But both aren't supported by Monaco.

@htcfreek So basically we can just add these as languages to display as plaintext. But we also can create our own languages.

@htcfreek
Copy link
Collaborator

I would like to have:

  • .ahk (AutoHotkey)
  • .au3 (AutoIT v3)
  • .inf (?)
  • .reg (Registry export)

But both aren't supported by Monaco.

@htcfreek So basically we can just add these as languages to display as plaintext. But we also can create our own languages.

I know that we can create our own. But creating the definition is a bit complicated.

@Aaron-Junker Aaron-Junker mentioned this issue Feb 2, 2022
Closed
@crutkas
Copy link
Member

crutkas commented Feb 2, 2022

Add razor, should be cshtml

https://docs.microsoft.com/en-us/aspnet/core/mvc/views/razor?view=aspnetcore-6.0#:~:text=The%20Razor%20syntax%20consists%20of%20Razor%20markup%2C%20C%23%2C,found%20in%20Razor%20components%20files%20%28%20.razor%20%29.

via https://twitter.com/sandroriz/status/1488956920652341251

@crutkas
Copy link
Member

crutkas commented Feb 2, 2022

@Aaron-Junker I personally think this needs to be individual asks. This becomes a never ending task versus something that has a clear goal and outcome.

inf and VBS are straight forward as are the XMLs.

@Aaron-Junker
Copy link
Collaborator Author

@Aaron-Junker I personally think this needs to be individual asks. This becomes a never ending task versus something that has a clear goal and outcome.

inf and VBS are straight forward as are the XMLs.

I personally find it easier to keep the overview in a sigle issue

@crutkas
Copy link
Member

crutkas commented Feb 3, 2022

I hear you but we can’t track / group work and have a tangible end in sight. Issues should have a tangible end. Adding stuff above, we have the ability.

@Aaron-Junker
Copy link
Collaborator Author

I hear you but we can’t track / group work and have a tangible end in sight. Issues should have a tangible end. Adding stuff above, we have the ability.

Ok let's keep this issue here with these file types and let future issues be standalone ones.

@dougLegard
Copy link

Can we add .bat and .cmd to the list before it closes?

@Aaron-Junker
Copy link
Collaborator Author

Can we add .bat and .cmd to the list before it closes?

Hi @dougLegard

These file types are already supported. Are you sure they don't work?

@dougLegard
Copy link

These file types are already supported. Are you sure they don't work?

I apologise, turns out I had registered these with a different preview handler in the past, restored them to default and they work fine now.
Thank you for this amazing improvement to windows.

@Aaron-Junker Aaron-Junker mentioned this issue Mar 21, 2022
Merged
10 tasks
@franky920920 franky920920 mentioned this issue Apr 4, 2022
Closed
@jaimecbernardo jaimecbernardo added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 14, 2022
@pedroaugustosmribeiro
Copy link

Please add preview for IDL source code files (.pro).
It would also be nice to have some documentation page about how to write custom language definition files for the Monaco Preview Handler.

@Aaron-Junker
Copy link
Collaborator Author

Please add preview for IDL source code files (.pro). It would also be nice to have some documentation page about how to write custom language definition files for the Monaco Preview Handler.

I'm currently working on these docs. Stay tuned!

@Aaron-Junker Aaron-Junker removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 12, 2022
@Aaron-Junker Aaron-Junker self-assigned this May 12, 2022
@crutkas
Copy link
Member

crutkas commented May 27, 2022

@Aaron-Junker, can we close this issue out and make individual asks? 'forever' open issues are not my favs :)

@Aaron-Junker
Copy link
Collaborator Author

@Aaron-Junker, can we close this issue out and make individual asks? 'forever' open issues are not my favs :)

Yes

@crutkas crutkas closed this as completed May 27, 2022
@chip33 chip33 mentioned this issue Feb 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaron-Junker Aaron-Junker

Labels
Idea-Enhancement New feature or request on an existing product Product-File Explorer Power Toys that touch explorer like Preview Pane Tracker Issue that is used to collect multiple sub-issues about a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@crutkas @pedroaugustosmribeiro @jaimecbernardo @Aaron-Junker @htcfreek @dougLegard