-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Settings UX] - Improved design for the ImageResizer sizes table. #2813
Comments
There is some work needed, yes. Maybe we should move towards a more extended dialog when adding/editing an item (like keyboard manager). This way we can visually improve the listview and optimize it for reading it while providing a better editor (with e.g. proper labels etc.) |
I am not shure if we realy need extendet dialogs. 🤔 More dialog means mor clicks for the user. I prefere easy and fast managable dialogs. |
A listview is meant to display items. If you make them editable a datagrid would be more appropiate. With dialog I meant a single click to open the listview item and to be able to edit its properties. Here we can use proper labels to indicate all items can do, making it scalable in the long term if we want to add more properties. Keyboard manager is a bad example since it goes against common UX patterns, but this is due some technical restrictions that we can hopefully tackle in the future. |
When DataGrid is added to WinUI proper, then it would be appropriate in this use case |
W10 Settings app does not work with inline datagrids, like we're doing: ListView items can be configured, but always requires you to select the object first. You can see this under e.g. Bluetooth or the Languages page: For ImageResizer it could look something like this (super quick mock-up): This would require the user to click on the list item to open up the dialog that would allow you to enter or update the settings. The user can delete an item by right-clicking? Advantages:
My 2cts :). Related to: #1053 |
@niels9001 But two things:
|
Oh yes, there's plenty of stuff missing from the dialog I think - if we'd agree and start any work related to this we definitely need to rethink that. |
@niels9001 |
Looking good, @niels9001. But I don't understand the possibility to set different units for width and height. That just doesn't make sense to me and I think it will mostly be either confusing or conflicting with each other. |
@Jay-o-Way Ah yes, you're right. The unit box should be a single box applying to both width and height. Too much copy-and-paste :) |
@niels9001 The double controls (width & height unit) are also visible in the UX of #1053 Personal opinion: I like the possibility to edit the presets "inline", that would remove the need for the extra Edit window. But a pop-up window feels better. |
Maybe I'm late, but recently I had a lightbulb turning on. There are two (general) design ways for these kind of settings.
The advantage of 2 is that you have more space to show extra information. Also, you can use this single gui for two occasions: coming from the settings window, and coming from the Image Resizer. I am in favor of number 2 now. What do you think? |
@enricogior fyi, i'm adding this to https://github.com/microsoft/PowerToys/wiki/Roadmap as it has been brought up multiple times |
Adding a reference to #4490 since it seems a nice option to add to the improved UI. |
@enricogior Is that work already planned for (e.g. 0.35 or beyond)? |
@niels9001 |
Resolved. Thanks @niels9001! |
We should restructure the table to make it easier to visually capture the table.
Original
Proposal
The text was updated successfully, but these errors were encountered: