Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new characters (Ğğ Üü Şş Iı Öö Çç Êê Ûû Îî Ẍẍ Ɫɫ Řř Ḧḧ) #20317

Open
OmerQadirFM opened this issue Sep 7, 2022 · 6 comments
Labels
Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Tracker Issue that is used to collect multiple sub-issues about a feature

Comments

@OmerQadirFM
Copy link

OmerQadirFM commented Sep 7, 2022

Description of the new feature / enhancement

please add these characters we as Kurds and Turks need these (Ğğ Üü Şş Iı Öö Çç Êê Ûû Îî Ẍẍ Ɫɫ Řř Ḧḧ) to Quick Accent

Scenario when this would be used?

more than 70 millions Kurds and 100 millions Turks need these characters to Quick Accent

Supporting information

No response

@OmerQadirFM OmerQadirFM added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 7, 2022
@OmerQadirFM OmerQadirFM changed the title Adding new characters (Ğğ Üü Şş Iı Öö Çç Êê Ûû Îî Ẍẍ Xx Ɫɫ Řř Ḧḧ) Adding new characters (Ğğ Üü Şş Iı Öö Çç Êê Ûû Îî Ẍẍ Ɫɫ Řř Ḧḧ) Sep 7, 2022
@Aaron-Junker Aaron-Junker added Product-Quick Accent Refers to the Quick Accent PowerToy Idea-Enhancement New feature or request on an existing product labels Sep 7, 2022
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Sep 7, 2022

We have numerous of requests like this and I'm going to point them towards these. @crutkas might want to pin this to the top of the list?

@Jay-o-Way Jay-o-Way mentioned this issue Sep 7, 2022
1 task
@Jay-o-Way Jay-o-Way added Tracker Issue that is used to collect multiple sub-issues about a feature and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 7, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Sep 7, 2022

@Jay-o-Way
Can you please stop merging the issues if they are for different letters. We need to track them separately to not miss all the different letter variants.

wmentha added a commit to wmentha/PowerToys that referenced this issue Sep 8, 2022
@dima-f1
Copy link

dima-f1 commented Sep 8, 2022

As said in the description

Quick Accent is an easy way to write letters with accents. like on the phone.

So I believe the easiest way to develop will be simply to take the phone and check if all characters from the phone are implemented. For now, also many characters from the polish alphabet are missing

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 10, 2022

@wmentha
Are you working on this?

@crutkas
Copy link
Member

crutkas commented Sep 10, 2022

I think what could be helpful here is to create groupings with an option for showing everything.

@wmentha
Copy link
Contributor

wmentha commented Sep 11, 2022

@htcfreek I've begun compiling a large (perhaps too large) list of Latin diacritics which can be seen here: main...wmentha:PowerToys:AccentPair

We can go over which are relevant and which aren't together. I've found myself including everything from medieval scribal abbreviations to insular script so I'll need someone reign me in 😅 There are a lot of diacritic combinations out there in use in the real world. And what about this character: Could that be considered a diacritic? I threw it in...

Given the sheer amount of accents out there, it is necessary that we offer the user a settings menu for turning on/off accents as well as allowing them to create their own minuscule / majiscule pairs: #20360 #20312 #20393

Speaking of pairs, instead of listing just the lowercase character and then calling .NETs culture invariant uppercase conversion function, it is better to explicitly list both characters together. Take this issue for example: #20332 .NET does not convert ß to There are also examples of lowercase characters that have no uppercase equivalent or vice versa.

  • has no uppercase equivalent
  • ı to uppercase is just capital i: I. So no reason to present it in toolbar (used in Turkish alphabet)
  • İ to lowercase is just i. So no reason to present it in toolbar

Given these exceptions, instead of manually filtering for them like #20356 I think it's best to group lower/upper case characters together as nullable pairs and filter out the nulls when presenting characters in the toolbar.

I've also added unique characters for currencies: #20339

Please be aware I haven't got around to updating my branch to be coherent with the terrific work done in #20190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea-Enhancement New feature or request on an existing product Product-Quick Accent Refers to the Quick Accent PowerToy Tracker Issue that is used to collect multiple sub-issues about a feature
Projects
Status: No status
Development

No branches or pull requests

7 participants