Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QuickAccent] Fixed ß uppercase bug #20356

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

Aaron-Junker
Copy link
Collaborator

Summary of the Pull Request

Adds support for an uppercase ß: ß

Apparently toUpper doesn't recognize this letter.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Aaron-Junker
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense. Thank you for the contribution.
Can you please remove the expected-lite update from this PR? I think that was added by mistake.

@Aaron-Junker
Copy link
Collaborator Author

Code makes sense. Thank you for the contribution.
Can you please remove the expected-lite update from this PR? I think that was added by mistake.

Yeah. This hapoens for every new branch i make. I will resolve it tomorrow

@Aaron-Junker
Copy link
Collaborator Author

Code makes sense. Thank you for the contribution. Can you please remove the expected-lite update from this PR? I think that was added by mistake.

@jaimecbernando This should now be fixed.

@Aaron-Junker
Copy link
Collaborator Author

What's holding this from getting merged

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 20, 2022
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit 789312c into main Sep 20, 2022
@Aaron-Junker Aaron-Junker deleted the dev/aaron-junker/20332 branch September 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants