-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QuickAccent] Fixed ß uppercase bug #20356
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense. Thank you for the contribution.
Can you please remove the expected-lite update from this PR? I think that was added by mistake.
Yeah. This hapoens for every new branch i make. I will resolve it tomorrow |
This reverts commit b5d26b7.
@jaimecbernando This should now be fixed. |
What's holding this from getting merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
Summary of the Pull Request
Adds support for an uppercase ß: ß
Apparently toUpper doesn't recognize this letter.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed