Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings should be localized #199

Closed
enricogior opened this issue Sep 5, 2019 · 24 comments
Closed

Strings should be localized #199

enricogior opened this issue Sep 5, 2019 · 24 comments
Assignees
@arjunbalgovind
Labels
Area-Localization issues regarding to Localization the application Product-FancyZones Refers to the FancyZones PowerToy Product-PowerRename Refers to the PowerRename PowerToy Product-Settings The standalone PowerToys Settings application Product-Shortcut Guide Refers to the Shortcut Guide PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Stability Release

Comments

@enricogior
Copy link
Contributor

enricogior commented Sep 5, 2019 •
edited by crutkas
Loading

Summary of the new feature/enhancement

The windows key shortcut guide UI strings need to be localized.

The application will be localized in the following langauges:

Language Culture Code
English en
German de
Spanish es
French fr
Italian it
Japanese ja
Korean ko
Portuguese (Brazil) pt-BR
Russian ru
Chinese (Simplified) zh-Hans
Chinese (Traditional) zh-Hant
Czech cs
Dutch nl
Hungarian hu
Portuguese (Portugal) pt-PT
Polish pl
Swedish sv
Turkish tr
@enricogior enricogior added Idea-Enhancement New feature or request on an existing product Product-Shortcut Guide Refers to the Shortcut Guide PowerToy labels Sep 5, 2019
@Rabattkarte
Copy link

Calling in from Germany - I'm more than happy to help with localization.

@bzoz bzoz mentioned this issue Sep 9, 2019
Closed
@enricogior enricogior added Area-Localization issues regarding to Localization the application and removed Idea-Enhancement New feature or request on an existing product labels Sep 10, 2019
@enricogior enricogior mentioned this issue Sep 10, 2019
Closed
@crutkas crutkas added this to the 0.16 milestone Dec 4, 2019
@crutkas
Copy link
Member

crutkas commented Dec 4, 2019

All hard coded strings in the application should be moved out into resource files so we can localize them, this includes settings. not just shortcut guide

@crutkas crutkas changed the title Shortcut guide strings should be localized Strings should be localized Dec 4, 2019
@crutkas crutkas added Product-FancyZones Refers to the FancyZones PowerToy Product-PowerRename Refers to the PowerRename PowerToy Product-Settings The standalone PowerToys Settings application labels Dec 4, 2019
This was referenced Dec 4, 2019
Closed
Closed
@crutkas
Copy link
Member

crutkas commented Dec 6, 2019

Once strings are put into resource files, we should be able to start doing localization off our internal build servers automatically

@enricogior
Copy link
Contributor Author

@crutkas
for Shortcut Guide we need to do this work item first #156, since the string are not even hard coded, they are images.

@crutkas crutkas mentioned this issue Dec 20, 2019
Closed
@alekhyareddy28 alekhyareddy28 self-assigned this Jan 10, 2020
@alekhyareddy28 alekhyareddy28 pinned this issue Jan 10, 2020
@alekhyareddy28 alekhyareddy28 added the Status-In progress This issue or work-item is under development label Jan 15, 2020
This was referenced Jan 16, 2020
Merged
Merged
Merged
alekhyareddy28 added a commit that referenced this issue Jan 21, 2020
@alekhyareddy28
Localizing C# Project of FancyZones (FancyZonesEditor) (#199) (#1122)
45e3f02 
* removed hardcoded strings from CanvasEditorWindow.xaml

* removed hardcoded strings from GridEditorWindow.xaml

* loc

* Localized MainWindow

* reverting MainWindow.xaml as it is not rendering the window as expected

* Changed the resource settings from internal to public

* the culture is set based on the culture of the system UI set in the system settings

* Removed the french resource files used for testing

* Localized canvasWindow and mainwindow

* Removed setting the UI culture explicitly as it would be implicitly set to the culture of system UI

* Removed redundant header file
@alekhyareddy28 alekhyareddy28 mentioned this issue Jan 21, 2020
Merged
3 tasks
alekhyareddy28 added a commit that referenced this issue Jan 22, 2020
@alekhyareddy28
Localize the Shortcut guide PowerToy (#199) (#1126)
1ad16ad 
* Localized shortcut_guide.cpp

* localized overlay_window.cpp

* formatting changes

* Localize overlay window

* removed the README link from the set of localized resources

* Typo: changed upper to lower
yuyoyuppe pushed a commit that referenced this issue Jan 23, 2020
@alekhyareddy28 @yuyoyuppe
Localizing C# Project of FancyZones (FancyZonesEditor) (#199) (#1122)
eddcc6d 
* removed hardcoded strings from CanvasEditorWindow.xaml

* removed hardcoded strings from GridEditorWindow.xaml

* loc

* Localized MainWindow

* reverting MainWindow.xaml as it is not rendering the window as expected

* Changed the resource settings from internal to public

* the culture is set based on the culture of the system UI set in the system settings

* Removed the french resource files used for testing

* Localized canvasWindow and mainwindow

* Removed setting the UI culture explicitly as it would be implicitly set to the culture of system UI

* Removed redundant header file
yuyoyuppe pushed a commit that referenced this issue Jan 23, 2020
@alekhyareddy28 @yuyoyuppe
Localize the Shortcut guide PowerToy (#199) (#1126)
8195b66 
* Localized shortcut_guide.cpp

* localized overlay_window.cpp

* formatting changes

* Localize overlay window

* removed the README link from the set of localized resources

* Typo: changed upper to lower
@enricogior enricogior mentioned this issue Sep 14, 2020
Closed
@enricogior enricogior mentioned this issue Oct 2, 2020
Closed
@crutkas crutkas mentioned this issue Oct 5, 2020
Closed
@htcfreek
Copy link
Collaborator

htcfreek commented Oct 8, 2020

Do we have a checklist of what has been translated so far and what still needs to be translated?
Then it would be possible to check the translated strings before the translated version is released.

@crutkas
Copy link
Member

crutkas commented Oct 8, 2020

verifying now

@crutkas
Copy link
Member

crutkas commented Oct 8, 2020

cs, de, es, hu, ko, pl-PL, tr should all be almost done and are checked in. hu i think is totally done. de is missing it looks like like, 30 out of 2500 items.

@htcfreek
Copy link
Collaborator

htcfreek commented Oct 8, 2020

cs, de, es, hu, ko, pl-PL, tr should all be almost done and are checked in. hu i think is totally done. de is missing it looks like like, 30 out of 2500 items.

This with de make sense. Have seen some not translated string in Launcher's resource file today.

@crutkas crutkas mentioned this issue Oct 10, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Oct 15, 2020

main translation is complete and merged in for all 17 languages

@htcfreek
Copy link
Collaborator

htcfreek commented Oct 15, 2020 •
edited
Loading

@crutkas
Have looked at the German translation of settings. Have seen that the module names were translated on some translations. This leads to interesting names and inconsistencies:

Example

Original Translsted into German Comment
About FacyZones Info zu FancyZones
About Color Picker Info zum Farbwähler
About Image Resizer Info zur Bildgrößenänderung Translated text says "Information on how to change image size" and not "Info about Image resizer tool"
About PowerToys Run Info zum PowerToys-Startprogramm
About File Explorer Info zum Datei-Explorer Translation says "Information about File Explorer". What about renaming into "File Explorer Addons"?

@arjunbalgovind arjunbalgovind added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Oct 15, 2020
@crutkas
Copy link
Member

crutkas commented Oct 16, 2020

@htcfreek please create new issues so we can be targeted. This is about the base amount of work.

@htcfreek
Copy link
Collaborator

@htcfreek please create new issues so we can be targeted. This is about the base amount of work.

Will be done later this day.

@htcfreek htcfreek mentioned this issue Oct 16, 2020
Closed
@crutkas crutkas mentioned this issue Oct 21, 2020
Closed
@tiziodcaio
Copy link

I can help with italian translation... How can I do it?

@htcfreek
Copy link
Collaborator

I can help with italian translation... How can I do it?

It's done automatically.

@enricogior
Copy link
Contributor Author

@tiziodcaio
you can help reporting bugs after we release the localized versions. Thanks,

@tiziodcaio
Copy link

Ok thanks

@crutkas
Copy link
Member

crutkas commented Oct 22, 2020

For incorrect translations, create new issues and we'll have the loc teams correct the translations

@crutkas crutkas mentioned this issue Oct 22, 2020
Closed
@enricogior enricogior mentioned this issue Oct 28, 2020
Closed
@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

added support for 17 total languages in 0.25 release!

@crutkas crutkas closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arjunbalgovind arjunbalgovind

Labels
Area-Localization issues regarding to Localization the application Product-FancyZones Refers to the FancyZones PowerToy Product-PowerRename Refers to the PowerRename PowerToy Product-Settings The standalone PowerToys Settings application Product-Shortcut Guide Refers to the Shortcut Guide PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Stability Release
Development

No branches or pull requests
10 participants
@crutkas @enricogior @Rabattkarte @eduardoaddad @bzoz @alekhyareddy28 @arjunbalgovind @tiziodcaio @htcfreek @Jay-o-Way