Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

fixed the missing get_uv_vectors. the function name was changed to get_orthogonal_vectors and it seems that the refactoring changed some cases but not all. #149

Merged
merged 3 commits into from
Apr 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Geometry/Transform.jl
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ function get_orthogonal_vectors(direction::Vec3{T}) where {T<:Real}
axis2 = normalize(cross(axis3, axis1))
return (axis2, axis3)
end
export get_orthogonal_vectors

#---------------------------------------
# 3D Transform / Local Frame
Expand Down
4 changes: 2 additions & 2 deletions src/Optical/Emitters/Directions.jl
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ struct RectGrid{T} <: AbstractDirectionDistribution{T}
vvec::Vec3{T}

function RectGrid(direction::Vec3{T}, halfangleu::T, halfanglev::T, numraysu::Integer, numraysv::Integer) where {T<:Real}
(uvec, vvec) = get_uv_vectors(direction)
(uvec, vvec) = get_orthogonal_vectors(direction)
return new{T}(direction, halfangleu, halfanglev, numraysu, numraysv, uvec, vvec)
end

Expand Down Expand Up @@ -112,7 +112,7 @@ struct UniformCone{T} <: AbstractDirectionDistribution{T}
vvec::Vec3{T}

function UniformCone(direction::Vec3{T}, θmax::T, numsamples::Integer) where {T<:Real}
(uvec, vvec) = get_uv_vectors(direction)
(uvec, vvec) = get_orthogonal_vectors(direction)
return new{T}(direction, θmax, numsamples, uvec, vvec)
end

Expand Down