Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

fixed the missing get_uv_vectors. the function name was changed to get_orthogonal_vectors and it seems that the refactoring changed some cases but not all. #149

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

galran
Copy link
Collaborator

@galran galran commented Apr 27, 2021

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

…t_orthogonal_vectors and it seems that the refactoring changed some cases but not all.
@galran
Copy link
Collaborator Author

galran commented Apr 27, 2021

get_uv_vectors => get_orthogonal_vectors

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #149 (391ac12) into main (9595f11) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   50.71%   50.77%   +0.06%     
==========================================
  Files          66       66              
  Lines        6470     6470              
==========================================
+ Hits         3281     3285       +4     
+ Misses       3189     3185       -4     
Impacted Files Coverage Δ
src/Geometry/Transform.jl 38.02% <ø> (ø)
src/Optical/Emitters/Directions.jl 5.47% <0.00%> (ø)
src/Optical/LensAssembly.jl 56.17% <0.00%> (+0.61%) ⬆️
src/Optical/OpticalSystem.jl 36.21% <0.00%> (+0.64%) ⬆️
src/Optical/Fresnel.jl 97.40% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9595f11...391ac12. Read the comment docs.

@BrianGun BrianGun merged commit 79d814d into main Apr 28, 2021
@BrianGun BrianGun deleted the galran/issue146 branch April 28, 2021 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants