Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Example for deterministic raytracing #130

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Conversation

cdhf
Copy link
Contributor

@cdhf cdhf commented Apr 21, 2021

Fixes #110.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #130 (d41402b) into main (8a55465) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   48.37%   48.37%           
=======================================
  Files          65       65           
  Lines        6659     6659           
=======================================
  Hits         3221     3221           
  Misses       3438     3438           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a55465...d41402b. Read the comment docs.

@BrianGun BrianGun enabled auto-merge (squash) April 21, 2021 22:15
@BrianGun
Copy link
Contributor

@cdhf thank you for this example.

@BrianGun BrianGun closed this Apr 21, 2021
auto-merge was automatically disabled April 21, 2021 22:16

Pull request was closed

@BrianGun BrianGun reopened this Apr 21, 2021
@BrianGun
Copy link
Contributor

BrianGun commented Apr 21, 2021

@alfredclwong doc preview cleanup is failing and maybe preventing this from being merged into main. Or something else is because it didn't get merged.

Could you take a look at this?

@alfredclwong
Copy link
Collaborator

alfredclwong commented Apr 21, 2021

It looks like the auto merge was cancelled because you closed the PR before it had a chance to merge (the doc build hadn't finished yet). You should just leave the PR to resolve itself once auto merge is set up.

It also looks like you didn't approve the PR? Not 100% sure as I'm checking from my phone.

Doc Preview Cleanup (and any other non-required checks) will not block merging.

@alfredclwong alfredclwong enabled auto-merge (squash) April 21, 2021 22:47
Copy link
Collaborator

@alfredclwong alfredclwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@alfredclwong alfredclwong merged commit 40ecade into microsoft:main Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example showing new pseudo-sequential ray tracing usage
4 participants