-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
sync to upstream
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 48.37% 48.37%
=======================================
Files 65 65
Lines 6659 6659
=======================================
Hits 3221 3221
Misses 3438 3438 Continue to review full report at Codecov.
|
@cdhf thank you for this example. |
@alfredclwong doc preview cleanup is failing and maybe preventing this from being merged into main. Or something else is because it didn't get merged. Could you take a look at this? |
It looks like the auto merge was cancelled because you closed the PR before it had a chance to merge (the doc build hadn't finished yet). You should just leave the PR to resolve itself once auto merge is set up. It also looks like you didn't approve the PR? Not 100% sure as I'm checking from my phone. Doc Preview Cleanup (and any other non-required checks) will not block merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Fixes #110.