sync to upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix UndefVarError: sources not defined Fixes #67 sources and all_start_time not defined. Defined them. Added test set to ensure function executes correctly instead of crashing. * Fix UndefVarError: sources not defined Fixes #67 removing Revise from project.toml
* OpenGL fails on Windows tests Fixes #74 turned off calls to Vis if OS is windows. * added comment * OpenGL fails on Windows tests Fixes #74 fixed error in the way Sys.iswindows was called. * skip vis tests if we're in a Windows CI environment * bump patch to v0.3.2 Co-authored-by: Alfred Wong <[email protected]>
* added the new Geometry module and split the file into the core geometry and geometry functions override (mainly multiplication by a transform).
next step is to remove the old RigidBodyTransform and replace it with the new Transform.
* remove the RigidBodyransform switched to the new Tansform.
package-wide small changee, including tests, CSG and other places.
next, will try to find the test issues of unwanted allocations.
* HTTP version limit created a bunch of limitation with JSServe and WGLMakie that prevented all kind of other packages versions.
* small changes to Transform to negate compiler inability to infer specific sizes which resulted is un-wanted allocations.
after this change all tests passed successfully.
* remove the old file RigidTransform.jl and Transform2.jl
moved all the Transform application functions (overiding the * operators to apply transform to different types) to their appropriate locations (Interval, Triangle, TriangleMesh, Intersection, Rays)
* forgot to remove the reference to Transform2.jl - fixed
* doing some cleaning up and removing old commented code.
will work on the documentation next.
* added some documentation and eliminated all the expansion operator uses.
* changed the documentation to describe the new Transform, Vec3 and Vec4 types (replacing the RigidBodyTransform).
added a new page (basic_types.md).
this is my first attempt at documentation, so please check well.
* fixed last places that used/referenced the old RigidBodyTRansform, including in the examples file and documentation.
* move the Geometry module declaration to the Geometry.jl file (instead of Transformjl).
fixed a typo in the documentation.
* fix missed RigidBodyTransform
* removed the origin3 and origin4 methods - we still have zero3 or zero4 and we can also use the LinearAlgebra methods, such as zeors(Vec3) ones(Vec4).
improved some declarations in Transform.jl according to Brian's recomendation.
Changed the Transform type to be identical to an SMatrix{4, 4, T 16}
removed identityT and left only identitytransform.
added the basic_types.md page to the help generation process.
Co-authored-by: Alfred Wong <[email protected]>
Fixes #76
* added the Emitters module. next going to add the new emitters' documentation. * added some docstrings to the emitters components, exported the Source and CompositeSource data types and added a docmentation page for the new emitters. also added the using of the OpticSim.Emitters to the documentation script.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: BrianGun <[email protected]>
1. update docs to reflect renaming of GlassCat.glasses ->
GlassCat.glassnames
2. restore docstring for isair()
fixes #81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.