Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Bump version number #77

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Bump version number #77

merged 1 commit into from
Apr 3, 2021

Conversation

BrianGun
Copy link
Contributor

@BrianGun BrianGun commented Apr 2, 2021

Pull Request Template

Description

Bumping version number because of breaking change caused by new Transform code.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just a version number change

  • Test A
  • Test B

Test Configuration(s):

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

1 similar comment
@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@codecov-io
Copy link

codecov-io commented Apr 2, 2021

Codecov Report

Merging #77 (30bd529) into main (28bf694) will decrease coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   51.69%   50.76%   -0.93%     
==========================================
  Files          54       53       -1     
  Lines        6092     6049      -43     
==========================================
- Hits         3149     3071      -78     
- Misses       2943     2978      +35     
Impacted Files Coverage Δ
src/Geometry/Primitives/Qtype.jl 75.00% <0.00%> (-8.34%) ⬇️
src/Optical/LensAssembly.jl 48.22% <0.00%> (-7.33%) ⬇️
src/Optical/OpticalInterface.jl 62.68% <0.00%> (-4.42%) ⬇️
src/Geometry/CSG/Intersection.jl 48.57% <0.00%> (-2.14%) ⬇️
src/Geometry/Geometry.jl 0.00% <0.00%> (-1.86%) ⬇️
src/Geometry/CSG/Interval.jl 83.20% <0.00%> (-0.37%) ⬇️
src/Geometry/Primitives/Curves/BSpline.jl 77.51% <0.00%> (-0.35%) ⬇️
src/Geometry/CSG/CSG.jl 84.88% <0.00%> (-0.06%) ⬇️
src/GlassCat/GlassCat.jl
src/Geometry/Primitives/Curves/Knots.jl 92.30% <0.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28bf694...30bd529. Read the comment docs.

@BrianGun BrianGun requested review from galran and alfredclwong April 3, 2021 02:31
@BrianGun BrianGun merged commit 4141f69 into main Apr 3, 2021
@BrianGun BrianGun deleted the BrianGun/issue76 branch April 3, 2021 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants