-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates navigation property expansion logic #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this also replace #152?
You probably need to update the integration test files as well.
@baywet this PR does not replace that #152. This one just deals with the expansion logic of containment navigation properties, the other issue has to do with "turning off" containment of some navigation properties without setting |
ok thanks for confirming. I believe then that #158 does what this does and more, there's just a last minute bug in there I need to address, but please have a look at the code and tell me what you think. |
I'm unable to run the branch on that PR due to the bug, but from a quick look at the expansion logic of containment navigation properties I don't see where it has modified the current experience. |
Don't check on the defining type to determine whether or not to expand, but on whether the navigation property has already been navigated in the path
Co-authored-by: Vincent Biret <[email protected]>
looks good to me. |
Fixes #123
This PR proposes:
NB: This approach expands on all containment navigation properties. This ends up exploding the number of paths significantly.