Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses Referenceable annotation to control generation of $ref paths #152

Merged
merged 8 commits into from
Feb 8, 2022
Merged

Uses Referenceable annotation to control generation of $ref paths #152

merged 8 commits into from
Feb 8, 2022

Conversation

irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented Dec 8, 2021 •
edited
Loading

Fixes #151
Fixes microsoftgraph/microsoft-graph-devx-api#754

This PR proposes:

  • Introducing and using a Referenceable annotation to control the generation of $ref paths. This helps in the separation of using ContainsTarget=false or the absence of this attribute in a navigation property as a condition for generating $ref paths.
  • Updating the relevant tests and integration test files to validate the above.

@irvinesunday irvinesunday added this to the 1.0.10 milestone Dec 8, 2021
@irvinesunday irvinesunday self-assigned this Dec 8, 2021
@irvinesunday irvinesunday force-pushed the is/read-custom-attributes branch from 12c0421 to 1101648 Compare December 9, 2021 11:00
@irvinesunday irvinesunday mentioned this pull request Jan 17, 2022
Merged
@irvinesunday irvinesunday force-pushed the is/read-custom-attributes branch from bd3b942 to cc5fa71 Compare February 2, 2022 10:12
@irvinesunday irvinesunday changed the title Implements custom XML attribute to control expansion of containment navigation properties Using Referenceable annotation to control generation of $ref paths Feb 2, 2022
@irvinesunday irvinesunday changed the title Using Referenceable annotation to control generation of $ref paths Uses Referenceable annotation to control generation of $ref paths Feb 2, 2022
@irvinesunday irvinesunday merged commit 1ca0f1b into master Feb 8, 2022
@irvinesunday irvinesunday deleted the is/read-custom-attributes branch February 8, 2022 09:21
@irvinesunday irvinesunday mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisspre chrisspre chrisspre left review comments

@xuzhg xuzhg xuzhg left review comments

@mikepizzo mikepizzo mikepizzo left review comments

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@peombwa peombwa Awaiting requested review from peombwa

@danielmbaluka danielmbaluka Awaiting requested review from danielmbaluka

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
OData:1.0.10
6 participants
@irvinesunday @darrelmiller @baywet @mikepizzo @xuzhg @chrisspre