Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LostTrackingService for Unity 2020 and XRSDK/WMR #8282

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Update LostTrackingService for Unity 2020 and XRSDK/WMR #8282

merged 3 commits into from
Aug 18, 2020

Conversation

keveleigh
Copy link
Contributor

@keveleigh keveleigh commented Aug 11, 2020 •
edited
Loading

Overview

Updates the LostTrackingService to no longer call into removed legacy XR APIs (WorldManager) on Unity 2020.
Also adds support for the replacement APIs in ARSubsystems' XRSessionSubsystem. This required a new reference to that assembly, and I reused the existing ARFOUNDATION_PRESENT define, since have ARFoundation implies ARSubsystems.

Changes

@keveleigh keveleigh added MRTK2 Extension Issue pertaining to an MRTK Extension Platform - XR SDK For Issues and PRs related to Unity's XR SDK pipeline. Unity 2020 labels Aug 11, 2020
@keveleigh keveleigh added this to the MRTK 2.5.0 milestone Aug 11, 2020
@keveleigh keveleigh self-assigned this Aug 11, 2020
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh
Copy link
Contributor Author

Adding DO NOT MERGE while I investigate using ARSessionSubsystem instead, which would help make this more cross-compatible.

@keveleigh keveleigh requested a review from wiwei as a code owner August 12, 2020 00:28
@microsoft microsoft deleted a comment from azure-pipelines bot Aug 12, 2020
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh
Copy link
Contributor Author

Temporarily closing this out while I rethink the approach

@keveleigh keveleigh closed this Aug 12, 2020
@keveleigh keveleigh reopened this Aug 18, 2020
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

david-c-kline
david-c-kline approved these changes Aug 18, 2020
View reviewed changes
Copy link

@david-c-kline david-c-kline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@david-c-kline
Copy link

:shipit:

@keveleigh keveleigh merged commit 1bbb698 into microsoft:mrtk_development Aug 18, 2020
@keveleigh keveleigh deleted the losttrackingservice-2020 branch August 18, 2020 21:56
@AMollis AMollis mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-c-kline david-c-kline david-c-kline approved these changes

@Railboy Railboy Awaiting requested review from Railboy

@wiwei wiwei Awaiting requested review from wiwei

Assignees

@keveleigh keveleigh

Labels
MRTK2 Extension Issue pertaining to an MRTK Extension Platform - XR SDK For Issues and PRs related to Unity's XR SDK pipeline. Unity 2020
Projects
None yet
Milestone
MRTK 2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@keveleigh @david-c-kline