Update config checker to be aware of XR SDK #7655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
added
the
Platform - XR SDK
keveleigh
force-pushed
the
update-config-checker-for-xr-sdk
branch
2 times, most recently
from
5633213
to
c23d98c
Compare
keveleigh
force-pushed
the
update-config-checker-for-xr-sdk
branch
from
c23d98c
to
068f281
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wiwei
approved these changes
Apr 14, 2020
david-c-kline
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
First pass on making the configurator XR SDK aware. In this, a
boolis added toXRSettingsUtilitieswhich checks if an XR SDK plug-in is installed which disables legacy VR. In this PR, this stops the check for VR enabled from running, since the legacy API was always being checked against and returns false when an XR SDK package is installed. This was causing the configurator to pop-up on every asset reload when XR SDK is enabled.Next pass would be to see if there's a way to configure the XR SDK loaders from code.
Changes