[python-package] remove MSVS solution files from sdist #6698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
StrikerRUS
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
LGTM, thank you for removing unused content!
I guess this line can also be safely removed now
Line 307 in b7de71d
|
Ah good point! I just pushed a commit removing that line too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my understanding from #6689 (comment), the
.slnand.vcxprojfiles in thewindows/directory are intended for use in the Visual Studio GUI, and don't need to be included in the source distribution of the Python package ("sdist").This proposes removing them, to make the sdist on PyPI slightly smaller.