[ci] set MinimumVisualStudioVersion to MSVS 2015
#6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez and
borchero
as code owners
shiyu1994
approved these changes
Oct 25, 2024
jameslamb
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
I really need to research how this .sln file is used, apologies for the potentially naive question... is this used at all in programmatic CMake builds (like invoking cmake --build)? Or is it only used in the MSVS GUI?
If it is used by programmatic CMake builds... could this change possibly allow us to revert the workaround from #6451?
|
I merged this because it seems like a good change anyway, and if the answer to my question is "yes", we can always address that in a follow-up PR. |
|
@jameslamb I don't think this |
|
Ah perfect, thanks for those links! This makes more sense to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version was taken from here: https://omwtm.blog/2014/12/03/visual-studio-2013-version-numbers-and-updates/.