Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Windows artifacts in windows-2019 image instead of vs2017-win2016 #5059

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Mar 7, 2022

Closed #4748.

Refer to https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml and https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md.

I'm not sure but it looks like our new Windows artifacts won't be compatible with VC Redistributable 2015 and 2017.

Visual Studio versions since Visual Studio 2015 share the same redistributable files. For example, any apps built by the Visual Studio 2015, 2017, 2019, or 2022 toolsets can use the latest Microsoft Visual C++ Redistributable. However, the version of the Microsoft Visual C++ redistributable installed on the machine must be the same or higher than the version of the Visual C++ toolset used to create your application.
https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#notes

For example, Visual Studio 2019 redistributable files may be used by apps built by using the Visual Studio 2017 or 2015 toolset. While they may be compatible, we don't support using older redistributable files in apps built by using a newer toolset. For example, using the 2017 redistributable files in apps built by using the 2019 toolset isn't supported.
https://docs.microsoft.com/en-us/cpp/windows/determining-which-dlls-to-redistribute?view=msvc-170

@StrikerRUS StrikerRUS marked this pull request as ready for review March 7, 2022 23:17
@StrikerRUS StrikerRUS requested a review from jameslamb as a code owner March 7, 2022 23:17
@StrikerRUS
Copy link
Collaborator Author

This PR should be merged before March 15 to not break our CI services.

@StrikerRUS
Copy link
Collaborator Author

There is an ongoing discussion for supporting Visual Studio 2017 in windows-2019 image. Probably worth a subscription:

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I agree that it seems we have no other option, given the significant effort it seems would be required to use Windows containers and the lack of interest from Microsoft/GitHub in the various issues linked to this PR.

@StrikerRUS StrikerRUS merged commit faccbb8 into master Mar 12, 2022
@StrikerRUS StrikerRUS deleted the bump_ci_win_image branch March 12, 2022 01:08
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows-2016 Azure Pipelines environment is deprecated
3 participants